You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "sunjincheng (JIRA)" <ji...@apache.org> on 2019/06/11 09:34:00 UTC
[jira] [Comment Edited] (FLINK-12776) Ambiguous content in
flink-dist NOTICE file
[ https://issues.apache.org/jira/browse/FLINK-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860737#comment-16860737 ]
sunjincheng edited comment on FLINK-12776 at 6/11/19 9:33 AM:
--------------------------------------------------------------
For a short summary, we have three optional solutions(for 1.9):
1. rename the module name: such as: `flink-api-python`, `flink-py` etc.
2. excluding the old `flink-libraries\flink-python` from flink-dist. (current the dist JAR name is `flink-python-1.9-SNAPSHOT-java-binding.jar` and `flink-python_2.11-1.9-SNAPSHOT.jar`).
3. add a little explanation in the licensing file, such as: `flink-python-java-binding` or `flink-python submodule of flink-parent` or other text.
From the points of my view, I like #3 for 1.9 release.
What do you think?
was (Author: sunjincheng121):
For a short summary, we have three optional solutions(for 1.9):
1. rename the module name: such as: `flink-api-python`, `flink-py` etc.
2. excluding the old `flink-libraries\flink-python` from flink-dist. (current the dist JAR name is `flink-python-1.9-SNAPSHOT-java-binding.jar` and `flink-python_2.11-1.9-SNAPSHOT.jar`.
3. add a little explanation in the licensing file, such as: `flink-python-java-binding` or `flink-python submodule of flink-parent` or other text.
From the points of my view, I like #3 for 1.9 release.
What do you think?
> Ambiguous content in flink-dist NOTICE file
> -------------------------------------------
>
> Key: FLINK-12776
> URL: https://issues.apache.org/jira/browse/FLINK-12776
> Project: Flink
> Issue Type: Improvement
> Components: API / Python, Release System
> Affects Versions: 1.9.0
> Reporter: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.9.0
>
> Attachments: image-2019-06-10-09-39-06-637.png
>
>
> With FLINK-12409 we include the new flink-python module in flink-dist. As a result we now have 2 {{flink-python}} entries in the flink-dist NOTICE file, one for the old batch API and one for the newly added one, which is ambiguous. We should rectify this by either excluding the old batch API from flink-dist, or rename the new module to something like {{flink-api-python}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)