You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/08 04:14:05 UTC
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4988
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 29 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4988/1
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
PS3, Line 1073: LOG_STRING(INFO, lines) << schema->DebugRow(input_row.row) <<
: " Undos: " + Mutation::StringifyMutationList(*schema, input_row.undo_head) <<
: " Redos: " + Mutation::StringifyMutationList(*schema, input_row.redo_head);
> It does. good catch. done
Ended up reverting this. Turns out a bunch of tests rely on this being printed in this exact format. A fight for another day :)
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
PS3, Line 823: 3
> Not a review comment per se, was it intentional to keep Input row loglevel
No, didn't really change it, but it does make sense to keep them together. Changed both to 4 since this is very verbose
PS3, Line 1073: LOG_STRING(INFO, lines) << schema->DebugRow(input_row.row) <<
: " Undos: " + Mutation::StringifyMutationList(*schema, input_row.undo_head) <<
: " Redos: " + Mutation::StringifyMutationList(*schema, input_row.redo_head);
> Does it make sense to use one of the new functions here as well?
It does. good catch. done
http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.h
File src/kudu/tablet/compaction.h:
PS3, Line 235: Mutation* undo_head
> const Muntation* undo_head
Done
PS3, Line 235: Mutation* redo_head
> const Mutation* read_head
Done
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
PS3, Line 1073: LOG_STRING(INFO, lines) << schema->DebugRow(input_row.row) <<
: " Undos: " + Mutation::StringifyMutationList(*schema, input_row.undo_head) <<
: " Redos: " + Mutation::StringifyMutationList(*schema, input_row.redo_head);
Does it make sense to use one of the new functions here as well?
http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.h
File src/kudu/tablet/compaction.h:
PS3, Line 235: Mutation* redo_head
const Mutation* read_head
?
PS3, Line 235: Mutation* undo_head
const Muntation* undo_head
?
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4988
to look at the new patch set (#2).
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 23 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4988/2
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4988
to look at the new patch set (#6).
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 24 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4988/6
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4988/2/src/kudu/tablet/compaction.h
File src/kudu/tablet/compaction.h:
PS2, Line 236: CompactionInputToString
> CompactionInput*Row*ToString?
Done
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4988
to look at the new patch set (#3).
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 23 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4988/3
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
PS3, Line 823: 3
Not a review comment per se, was it intentional to keep Input row loglevel different than output row loglevel (below) in this function ?
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4988/2/src/kudu/tablet/compaction.h
File src/kudu/tablet/compaction.h:
PS2, Line 236: CompactionInputToString
CompactionInput*Row*ToString?
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4988
to look at the new patch set (#5).
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 25 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4988/5
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Reviewed-on: http://gerrit.cloudera.org:8080/4988
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 24 insertions(+), 29 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4988
to look at the new patch set (#4).
Change subject: Consolidate Row/CompactionInputRow printing on compaction
......................................................................
Consolidate Row/CompactionInputRow printing on compaction
We are duplicating row printing code in a lot of places. This adds
a couple of methods to avoid that.
Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/delta_compaction.cc
3 files changed, 23 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4988/4
--
To view, visit http://gerrit.cloudera.org:8080/4988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd9f59094ac1f5f9c6343c77771d5770dcc089f9
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>