[GitHub] [lucene] uschindler commented on issue #11912: Can we improve MMapDir's exceptions for invalid offsets?

[GitBox <gi...@apache.org>]

uschindler commented on issue #11912:
URL: https://github.com/apache/lucene/issues/11912#issuecomment-1309351422

   As discussed in chat an hour ago:
   - for MemorySegmentIndexInput it already has a reworked Exception code where also those suppress unused warnings are gone due to some trick: we just catch the exception, but pass them to a method that maps it to an user readable Lucene exception and regrow it  This reduced code duplication and removed most suppress warnings.
   
   The code in memory segments already contains a message to report negative positions. I can change it to show the actual position.
   
   I would backport the exception factory methods to the byte buffer index input, that's a bit mechanical work but makes the code also better readable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org