[jira] [Comment Edited] (OAK-9509) Enable minimum line and branch test coverage for oak-jcr

["Angela Schreiber (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385355#comment-17385355 ] 

Angela Schreiber edited comment on OAK-9509 at 7/22/21, 8:58 AM:
-----------------------------------------------------------------

[~mreutegg], oh..... rats....  i will take a look and fix it.

rev. a3fb5f1db7..8634b87b9f : lowered required branch-coverage to the value reported by jenkins. i planned to cleanup the security related pieces in the delegate package and add some more tests there in a separate ticket. so, will keep an eye on it.


was (Author: anchela):
[~mreutegg], oh..... rats....  i will take a look and fix it.

> Enable minimum line and branch test coverage for oak-jcr
> --------------------------------------------------------
>
>                 Key: OAK-9509
>                 URL: https://issues.apache.org/jira/browse/OAK-9509
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Angela Schreiber
>            Assignee: Angela Schreiber
>            Priority: Minor
>             Fix For: 1.42.0
>
>
> today _jacoco-maven-plugin_ is skipped in _oak-jcr_ and thus doesn't record line/branch coverage. i would suggest to enable it by default. as of now line coverage is 72%, branch coverage is 60%.
> [~mreutegg], unless you have any concerns i would go ahead and add the 2 properties to the pom.xml:
> {code}
>     <skip.coverage>false</skip.coverage>
>     <minimum.coverage>0.72</minimum.coverage>
>     <minimum.branch.coverage>0.60</minimum.branch.coverage>
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)