You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2023/10/12 19:51:58 UTC
[PR] Support ./gradlew modernizer [solr]
risdenk opened a new pull request, #2006:
URL: https://github.com/apache/solr/pull/2006
https://issues.apache.org/jira/browse/SOLR-XXXXX
A long time ago I was looking at ways to improve the build process to detect out of date usages. This adds `./gradlew modernizer` that will find things that can be replaced.
based on https://github.com/andygoossens/gradle-modernizer-plugin
Haven't gone through the results yet but throwing this up in case anyone thinks its interesting. No use in only having it in a local branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Support ./gradlew modernizer [solr]
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #2006:
URL: https://github.com/apache/solr/pull/2006#issuecomment-1771383695
interesting. if they add this then yeah, I agree this change is on longer useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Support ./gradlew modernizer [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #2006:
URL: https://github.com/apache/solr/pull/2006#issuecomment-1777696769
Yea https://github.com/apache/solr/pull/2035 covers MOST of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Support ./gradlew modernizer [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #2006:
URL: https://github.com/apache/solr/pull/2006#issuecomment-1771161479
Interestingly errorprone https://github.com/google/error-prone/releases/tag/v2.23.0 might have just addressed the charset stuff so this PR might not be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Support ./gradlew modernizer [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #2006:
URL: https://github.com/apache/solr/pull/2006#issuecomment-1763405704
Yup @stillalex this is just finding MOSTLY charset related changes right now. There are some disabled - https://github.com/apache/solr/pull/2006/files#diff-9257ac5900027c3c54700c25c646e201f7fcec13c7f39ecedd288f99c0ecb5f2R30. I don't know if this is worth it. We have cleaned up a lot of older usages with errorprone already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Support ./gradlew modernizer [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk closed pull request #2006: Support ./gradlew modernizer
URL: https://github.com/apache/solr/pull/2006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org