You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2016/12/15 07:14:20 UTC

Review Request 54773: Add finer grained timings to the Snapshot process.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54773/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Zameer Manji.


Repository: aurora


Description
-------

Add finer grained timings to the Snapshot process. I also added some log output, as I found those existing numbers handy when investigating our long snapshot times. 

Related ticket: https://issues.apache.org/jira/browse/AURORA-1861


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39924c62108f6a68f545f90d77ceab4265d41fad 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java d2c859055f905ac76ee8eb387dca103b9857ddbe 

Diff: https://reviews.apache.org/r/54773/diff/


Testing
-------


Thanks,

David McLaughlin

Re: Review Request 54773: Add finer grained timings to the Snapshot process.

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54773/#review159268
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Dec. 14, 2016, 11:14 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54773/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 11:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add finer grained timings to the Snapshot process. I also added some log output, as I found those existing numbers handy when investigating our long snapshot times. 
> 
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1861
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39924c62108f6a68f545f90d77ceab4265d41fad 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java d2c859055f905ac76ee8eb387dca103b9857ddbe 
> 
> Diff: https://reviews.apache.org/r/54773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 54773: Add finer grained timings to the Snapshot process.

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54773/#review159266
-----------------------------------------------------------



Master (220e23b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 15, 2016, 7:14 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54773/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 7:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add finer grained timings to the Snapshot process. I also added some log output, as I found those existing numbers handy when investigating our long snapshot times. 
> 
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1861
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39924c62108f6a68f545f90d77ceab4265d41fad 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java d2c859055f905ac76ee8eb387dca103b9857ddbe 
> 
> Diff: https://reviews.apache.org/r/54773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 54773: Add finer grained timings to the Snapshot process.

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54773/#review159325
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On Dec. 14, 2016, 11:14 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54773/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 11:14 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add finer grained timings to the Snapshot process. I also added some log output, as I found those existing numbers handy when investigating our long snapshot times. 
> 
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1861
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39924c62108f6a68f545f90d77ceab4265d41fad 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java d2c859055f905ac76ee8eb387dca103b9857ddbe 
> 
> Diff: https://reviews.apache.org/r/54773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 54773: Add finer grained timings to the Snapshot process.

Posted by Joshua Cohen <jc...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54773/#review159302
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Dec. 15, 2016, 7:14 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54773/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 7:14 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add finer grained timings to the Snapshot process. I also added some log output, as I found those existing numbers handy when investigating our long snapshot times. 
> 
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1861
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39924c62108f6a68f545f90d77ceab4265d41fad 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java d2c859055f905ac76ee8eb387dca103b9857ddbe 
> 
> Diff: https://reviews.apache.org/r/54773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>