You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/15 22:29:37 UTC

[GitHub] [flink] syhily opened a new pull request, #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

syhily opened a new pull request, #19978:
URL: https://github.com/apache/flink/pull/19978

   ## What is the purpose of the change
   
   The PulsarMessageBuild.key(String) always return null, which cause NPE.
   
   ## Brief change log
   
   `return this` instead of `return null`
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #19978:
URL: https://github.com/apache/flink/pull/19978#issuecomment-1160181001

   I need to check out a backport PR for `release-1.15`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] imaffe commented on pull request #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

Posted by GitBox <gi...@apache.org>.
imaffe commented on PR #19978:
URL: https://github.com/apache/flink/pull/19978#issuecomment-1157163110

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19978:
URL: https://github.com/apache/flink/pull/19978#issuecomment-1157016182

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0384dee5b76b645ec0947dd208ce027cbce9717",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0384dee5b76b645ec0947dd208ce027cbce9717",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0384dee5b76b645ec0947dd208ce027cbce9717 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #19978: [FLINK-27881][Connector/Pulsar] Never return null for PulsarMessageBuilder

Posted by GitBox <gi...@apache.org>.
zentol merged PR #19978:
URL: https://github.com/apache/flink/pull/19978


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org