You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/31 03:51:05 UTC

[GitHub] [incubator-seatunnel] TaoZex commented on a diff in pull request #3237: [Hotfix][e2e] fix JobRestoreWhenMasterNodeSwitch method NP

TaoZex commented on code in PR #3237:
URL: https://github.com/apache/incubator-seatunnel/pull/3237#discussion_r1009008918


##########
seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/CoordinatorServiceTest.java:
##########
@@ -154,7 +154,7 @@ public void testJobRestoreWhenMasterNodeSwitch() throws InterruptedException {
             });
 
         // wait job restore
-        Thread.sleep(5000);
+        Thread.sleep(30000);

Review Comment:
   Agree with you, I think the problem is the code getJobMaster(jobId), which returns null when the master has not successfully switched.
   If we can't make sure job restore success now, we can either temporarily discard it or set the code Thread.sleep to a large value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org