You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2024/05/01 18:43:24 UTC
[PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
nickva opened a new pull request, #32:
URL: https://github.com/apache/couchdb-glazier/pull/32
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586646945
##########
bin/shell.ps1:
##########
@@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin"
$env:PATH += ";${vcpkgBase}\bin"
$env:PATH += ";C:\Program Files (x86)\WiX Toolset v3.11\bin"
$env:PATH += ";C:\tools\${java11Build}\bin"
+$env:PATH += ";C:\tools\msys64\ucrt64\bin"
Review Comment:
Short question, where is this path set?
##########
bin/install_dependencies.ps1:
##########
@@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) {
}
refreshenv
+Write-Output " ***** Seting up MSYS ******* "
Review Comment:
Small typo, should be `Setting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586814081
##########
bin/shell.ps1:
##########
@@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin"
$env:PATH += ";${vcpkgBase}\bin"
$env:PATH += ";C:\Program Files (x86)\WiX Toolset v3.11\bin"
$env:PATH += ";C:\tools\${java11Build}\bin"
+$env:PATH += ";C:\tools\msys64\ucrt64\bin"
Review Comment:
This is required for QuickJS https://github.com/apache/couchdb/pull/4627 to build on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586658315
##########
bin/install_dependencies.ps1:
##########
@@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) {
}
refreshenv
+Write-Output " ***** Seting up MSYS ******* "
Review Comment:
Oops, thanks for noticing, Ronny. Will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586661597
##########
bin/install_dependencies.ps1:
##########
@@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) {
}
refreshenv
+Write-Output " ***** Seting up MSYS ******* "
Review Comment:
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586657681
##########
bin/shell.ps1:
##########
@@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin"
$env:PATH += ";${vcpkgBase}\bin"
$env:PATH += ";C:\Program Files (x86)\WiX Toolset v3.11\bin"
$env:PATH += ";C:\tools\${java11Build}\bin"
+$env:PATH += ";C:\tools\msys64\ucrt64\bin"
Review Comment:
This is set by the msys2 install after chocolatey installs it. Here we're just making gcc.exe and ld.exe available to the build environment so when we `make` the `couch_quickjs` app we don't have to hard-code `c:\tools\...\gcc.exe` in there and can just use `gcc.exe ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1587028297
##########
bin/shell.ps1:
##########
@@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin"
$env:PATH += ";${vcpkgBase}\bin"
$env:PATH += ";C:\Program Files (x86)\WiX Toolset v3.11\bin"
$env:PATH += ";C:\tools\${java11Build}\bin"
+$env:PATH += ";C:\tools\msys64\ucrt64\bin"
Review Comment:
I had tired to uninstalled and clean all the msys2 bits, then re-install and it still went to `c:\tools\msys64` so at least on my laptop seems to end up in `c:\tools` I can't see where it's configured to do so...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #32:
URL: https://github.com/apache/couchdb-glazier/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org