Re: [VOTE] Release Apache NLPCraft (incubating) v 0.9.0

[Xun Liu <li...@apache.org>]

+1 (non-binding) from me, I have checked the following items:

- Incubating in name
- NOTICE is fine
- DISCLAIMER exists
- All links are valid
- No unexpected binary files
- All ASF files have ASF headers
- RUN：mvn clean package verify

Best regards
Xun Liu

On Sat, Jul 31, 2021 at 7:45 AM Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> +1 but only due to work in progress disclaimer. There are serval minor
> issues that need to be fixed.
>
> I checked:
> - incubating in name
> - signatures and hashes good
> - disclaimer exists
> - license is missing information on a file [6]
> - NOTICE is not correct. As mentioned on a previous release [1] there is
> no need to list licenses or unneeded copyright statement in NOTICE. If this
> is not fixed in a future release I will vote -1 on it.
> - source release contains compiled code [2][3][4][5]
> - This file incorrectly has an ASF header [6] and should be mention in
> LICENSE
>
> This release is hard to review as for some reason rat doesn’t recognise
> the headers on the scala files. This may have hidden some other issues.
>
> Kind Regards,
> Justin
>
> 1.
> https://lists.apache.org/thread.html/rf79136697625906cdbf723eeed3b710eb6f4256a39493bbc715238a0%40%3Cgeneral.incubator.apache.org%3E
> 2. ./nlpcraft/src/main/python/ctxword/__pycache__/server.cpython-38.pyc
> 3.
> ./nlpcraft/src/main/python/ctxword/bertft/__pycache__/__init__.cpython-38.pyc
> 4.
> ./nlpcraft/src/main/python/ctxword/bertft/__pycache__/bertft.cpython-38.pyc
> 5.
> ./nlpcraft/src/main/python/ctxword/bertft/__pycache__/utils.cpython-38.pyc
> 6.
> ./nlpcraft/src/main/scala/org/apache/nlpcraft/common/util/NCIdGenerator.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>