You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/23 22:19:11 UTC
[GitHub] [nifi] driesva opened a new pull request #4930: NIFI-4239 - Adding (updated) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logical Replication.
driesva opened a new pull request #4930:
URL: https://github.com/apache/nifi/pull/4930
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
This pull requests builds upon the original PR https://github.com/apache/nifi/pull/4065 from @gerdansantos.
(a new fork/branch was created due to lack of permissions and original commits were cherrypicked)
Together with my colleague @mathiasbosman, I evaluated the original code. We observed a couple of things:
- Java best practices not always followed
- Resources not optimal closed
- Sometimes poor exception handling
- Few bugs (e.g. inside decode logic for complex messages)
- No tests
- ...
This PR fixes many of those things and is targeted at 1.14.0-SNAPSHOT
There's still room for lots of improvements but that would take us to far. We just started using NiFi (and are not Postgres experts either)...
Some things which are still questionable:
- initial snapshot is loaded entirely in memory (so not to be used for large tables)
- motivation/decisions behind message formats (and their differences: snapshot vs simple vs complex)
Ideally both the MySQL CDC and Postgres CDC should use the same canonical message model. But that's out of scope for us.
Our main wish is to have a (minimal) Postgres CDC processor which is part of the official NiFi distribution, hence our intent to move the original PR forward.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. **--> existing JIRA NIFI-4239**
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? **--> partially, commits of original author left as individual commits**
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? **--> with -skipTests but Github actions builds pass**
- [x] Have you written or updated unit tests to verify your changes? **--> integration test**
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? **--> PostgreSQL JDBC Driver**
- [x] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [x] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered? **--> there wasn't any... no additional added...**
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4930: NIFI-4239 - Adding (updated) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logical Replication.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4930:
URL: https://github.com/apache/nifi/pull/4930#issuecomment-885314015
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #4930: NIFI-4239 - Adding (updated) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via Logical Replication.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4930:
URL: https://github.com/apache/nifi/pull/4930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org