You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/28 21:33:23 UTC
[PR] chore(frontend): migrate Sass @import to @use [texera]
Yicong-Huang opened a new pull request, #5987:
URL: https://github.com/apache/texera/pull/5987
### What changes were proposed in this PR?
Dart Sass deprecated `@import` (to be removed in Dart Sass 3.0); the frontend build emitted **29** `Sass @import rules are deprecated` warnings across 13 dashboard/hub component stylesheets.
These `@import`s only pull shared CSS rules from sibling stylesheets (`section-style`, `button-style`, `dashboard.component`, and a few sibling `*.component.scss`); no Sass variables, mixins, or functions are referenced across files (the only declared variables live inside `section-style.scss` and are used only there). So this is a mechanical migration: each `@import "X"` becomes `@use "X" as *`, which emits the same CSS in the same order while clearing the deprecation.
`as *` is used (rather than the default namespace) because Sass auto-derives the namespace from the filename, which is invalid for the dotted names here (e.g. `dashboard.component`). Since no members are referenced cross-file, `as *` is safe — there are no member collisions.
The plain CSS `@import` in `styles.scss` (`angular-tree-component.css`) is intentionally left as-is: it is a CSS import, not a Sass one, and is not affected by the deprecation.
### Any related issues, documentation, discussions?
Closes #5986
### How was this PR tested?
Ran `ng build` with these changes: Sass compiles cleanly, the **29** `@import` deprecation warnings drop to **0**, and the bundle is produced normally. CSS output ordering is preserved because the `@import`s were already at the top of each file (right after the license header), matching `@use` semantics.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): migrate Sass @import to @use [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5987:
URL: https://github.com/apache/texera/pull/5987#issuecomment-4827472345
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5987?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.23%. Comparing base ([`0e0ec11`](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1a2506b`](https://app.codecov.io/gh/apache/texera/commit/1a2506bc1b4d2750ad3ae00e4e7dafe7d9e392bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5987 +/- ##
=========================================
Coverage 56.23% 56.23%
Complexity 2987 2987
=========================================
Files 1120 1120
Lines 43167 43167
Branches 4658 4658
=========================================
+ Hits 24274 24277 +3
+ Misses 17472 17464 -8
- Partials 1421 1426 +5
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.77% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.30% <ø> (+0.02%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [0e0ec11](https://app.codecov.io/gh/apache/texera/commit/0e0ec11badcd19bdbd12995bcbbfdbb873354d3e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5987?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): migrate Sass @import to @use [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5987:
URL: https://github.com/apache/texera/pull/5987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): migrate Sass @import to @use [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5987:
URL: https://github.com/apache/texera/pull/5987#issuecomment-4827461091
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@xuang7`, `@mengw15`
You can notify them by mentioning `@aglinxinyuan`, `@xuang7`, `@mengw15` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org