[jira] [Commented] (HBASE-7262) Move HBaseRPC metrics to metrics2

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510294#comment-13510294 ] 

stack commented on HBASE-7262:
------------------------------

bq. removed when calls are above 1 second. That should be in HRegionServer's metrics as it will allow things to be much much faster (less looking things up by method name in a hashmap).

Is this a TODO?

On the patch...

MetricsHBaseServerSource missing license

... a few classes in here missing license

Should fix this kinda stuff:

+    assertNotNull("Should get gauge "+cName + " but did not",gauges.get(cName));

We put space after ',' and around operators like '+'

I like stuff like the below:

-  public HBaseRpcMetrics getRpcMetrics() {
-    return rpcServer.getRpcMetrics();
-  }

Patch looking good.
                
> Move HBaseRPC metrics to metrics2
> ---------------------------------
>
>                 Key: HBASE-7262
>                 URL: https://issues.apache.org/jira/browse/HBASE-7262
>             Project: HBase
>          Issue Type: Sub-task
>          Components: metrics
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7262-0.patch
>
>
> HBase RPC is the last thing still publishing through metrics1.  We should move this into metrics2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira