You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/06/20 06:09:04 UTC
[5/6] hbase git commit: HBASE-18212 reduce log level for unbuffer
warning.
HBASE-18212 reduce log level for unbuffer warning.
In Standalone mode with local filesystem HBase logs Warning message:Failed to invoke 'unbuffer' method in class org.apache.hadoop.fs.FSDataInputStream
Signed-off-by: Umesh Agashe <ua...@cloudera.com>
Signed-off-by: Sean Busbey <bu...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/af466bf7
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/af466bf7
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/af466bf7
Branch: refs/heads/master
Commit: af466bf722450ce6f61ee2bc1e26ab202dea7fb5
Parents: df06294
Author: Ashish Singhi <as...@apache.org>
Authored: Fri Jun 16 10:43:56 2017 +0530
Committer: Sean Busbey <bu...@apache.org>
Committed: Tue Jun 20 01:06:47 2017 -0500
----------------------------------------------------------------------
.../hbase/io/FSDataInputStreamWrapper.java | 27 ++++++++++++--------
1 file changed, 16 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/af466bf7/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
index 25a3373..fb6ebeb 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
@@ -42,6 +42,7 @@ import com.google.common.annotations.VisibleForTesting;
@InterfaceAudience.Private
public class FSDataInputStreamWrapper implements Closeable {
private static final Log LOG = LogFactory.getLog(FSDataInputStreamWrapper.class);
+ private static final boolean isLogTraceEnabled = LOG.isTraceEnabled();
private final HFileSystem hfs;
private final Path path;
@@ -274,10 +275,11 @@ public class FSDataInputStreamWrapper implements Closeable {
try {
this.unbuffer = streamClass.getDeclaredMethod("unbuffer");
} catch (NoSuchMethodException | SecurityException e) {
- LOG.warn("Failed to find 'unbuffer' method in class " + streamClass
- + " . So there may be a TCP socket connection "
- + "left open in CLOSE_WAIT state.",
- e);
+ if (isLogTraceEnabled) {
+ LOG.trace("Failed to find 'unbuffer' method in class " + streamClass
+ + " . So there may be a TCP socket connection "
+ + "left open in CLOSE_WAIT state.", e);
+ }
return;
}
this.instanceOfCanUnbuffer = true;
@@ -289,15 +291,18 @@ public class FSDataInputStreamWrapper implements Closeable {
try {
this.unbuffer.invoke(wrappedStream);
} catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
- LOG.warn("Failed to invoke 'unbuffer' method in class " + streamClass
- + " . So there may be a TCP socket connection left open in CLOSE_WAIT state.",
- e);
+ if (isLogTraceEnabled) {
+ LOG.trace("Failed to invoke 'unbuffer' method in class " + streamClass
+ + " . So there may be a TCP socket connection left open in CLOSE_WAIT state.", e);
+ }
}
} else {
- LOG.warn("Failed to find 'unbuffer' method in class " + streamClass
- + " . So there may be a TCP socket connection "
- + "left open in CLOSE_WAIT state. For more details check "
- + "https://issues.apache.org/jira/browse/HBASE-9393");
+ if (isLogTraceEnabled) {
+ LOG.trace("Failed to find 'unbuffer' method in class " + streamClass
+ + " . So there may be a TCP socket connection "
+ + "left open in CLOSE_WAIT state. For more details check "
+ + "https://issues.apache.org/jira/browse/HBASE-9393");
+ }
}
}
}