You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 09:00:02 UTC

[GitHub] [flink] smattheis opened a new pull request, #19569: [FLINK-24804][FLINK-25505] Upgrade oshi-core to version 6.1.5

smattheis opened a new pull request, #19569:
URL: https://github.com/apache/flink/pull/19569

   ## What is the purpose of the change
   
   * Upgrade oshi-core to version 6.1.5 (according to FLINK-24804) which resolves one issue of building and testing Flink on Apple M1 (see FLINK-25505)
   
   ## Brief change log
   
     - Simply adapted to changed interface
     - Update docs accordingly
     - Fix calculation of CPU load to include steal time according to oshi-core docs: *"To calculate overall Idle time using this method, include both Idle and IOWait ticks. Similarly, IRQ, SoftIRQ and Steal ticks should be added to the System value to get the total. System ticks also include time executing other virtual hosts (steal)."*
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   * Tests have been in place covering the changes as we simply upgrade oshi-core version.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **yes**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: J**no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys merged pull request #19569: [FLINK-24804][FLINK-25505] Upgrade oshi-core to version 6.1.5

Posted by GitBox <gi...@apache.org>.
dawidwys merged PR #19569:
URL: https://github.com/apache/flink/pull/19569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #19569: [FLINK-24804][FLINK-25505] Upgrade oshi-core to version 6.1.5

Posted by GitBox <gi...@apache.org>.
dawidwys commented on PR #19569:
URL: https://github.com/apache/flink/pull/19569#issuecomment-1112084736

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19569: [FLINK-24804][FLINK-25505] Upgrade oshi-core to version 6.1.5

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19569:
URL: https://github.com/apache/flink/pull/19569#issuecomment-1108291292

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fb3ee95530285e81f7184e7b5f8df989dc5a0a74",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb3ee95530285e81f7184e7b5f8df989dc5a0a74",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb3ee95530285e81f7184e7b5f8df989dc5a0a74 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org