You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/09/19 23:00:10 UTC
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4451
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Improve the debuggability of LogBlockContainer::CheckBlockRecord()
We're getting an error come up in the flaky tests that is hard to debug
because we don't print the data file size, which is the condition tripping
the check.
Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/4451/1
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Patch Set 2:
added printing out the file name
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4451
to look at the new patch set (#2).
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Improve the debuggability of LogBlockContainer::CheckBlockRecord()
We're getting an error come up in the flaky tests that is hard to debug
because we don't print the data file size, which is the condition tripping
the check. This also includes the filename of the data file where the
offending record was found in the printout.
Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/4451/2
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Improve the debuggability of LogBlockContainer::CheckBlockRecord()
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Improve the debuggability of LogBlockContainer::CheckBlockRecord()
......................................................................
Improve the debuggability of LogBlockContainer::CheckBlockRecord()
We're getting an error come up in the flaky tests that is hard to debug
because we don't print the data file size, which is the condition tripping
the check. This also includes the filename of the data file where the
offending record was found in the printout.
Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Reviewed-on: http://gerrit.cloudera.org:8080/4451
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e74537ea258e8c6a0ffa00b9f5d529a04ecd583
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>