You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/08/04 10:24:47 UTC

Re: Review Request 50784: [LENS-1257] Add ability to analyze sessions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50784/#review144737
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
<https://reviews.apache.org/r/50784/#comment210820>

    Can we avoid these formatting changes?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
<https://reviews.apache.org/r/50784/#comment210821>

    Seems some merge issues here



lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java (line 267)
<https://reviews.apache.org/r/50784/#comment210822>

    Can you include unit test for the api?


- Amareshwari Sriramadasu


On Aug. 4, 2016, 9:33 a.m., Lavkesh Lahngir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50784/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:33 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1257
>     https://issues.apache.org/jira/browse/LENS-1257
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Server side changes for session API.
> 
> P.S. Lots of changes are just formatting differences.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/java/org/apache/lens/api/session/UserSessionInfo.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 19a86c6 
>   lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java fdfd09c 
> 
> Diff: https://reviews.apache.org/r/50784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>