You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "sabir-akhadov-localstack (via GitHub)" <gi...@apache.org> on 2026/10/21 04:47:35 UTC
Re: [PR] SQLite: Tokenize parameters the way SQLite does [datafusion-sqlparser-rs]
sabir-akhadov-localstack commented on code in PR #2559:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2559#discussion_r4333132076
##########
src/dialect/sqlite.rs:
##########
@@ -42,6 +43,13 @@ impl Dialect for SQLiteDialect {
ch == '`' || ch == '"' || ch == '['
}
+ fn get_next_precedence(&self, parser: &Parser) -> Option<Result<u8, ParserError>> {
Review Comment:
#2683 already added `get_next_precedence` to this impl (`&`/`|` at `Precedence::Ampersand`); git auto-merges both without a marker and the result has two definitions, so fold the `Token::Colon` arm into that match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org