[GitHub] [beam] lukecwik commented on a change in pull request #11472: [BEAM-2939, BEAM-5602] Migrate from HasSize to HasProgress interface for restriction trackers and use the progress value during sizing, splitting and reporting

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11472:
URL: https://github.com/apache/beam/pull/11472#discussion_r414031067



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -311,9 +315,14 @@ private void createRunnerAndConsumersForPTransformRecursively(
       // Get finish bundle Execution Time Metrics.
       response.addAllMonitoringInfos(
           bundleProcessor.getFinishFunctionRegistry().getExecutionTimeMonitoringInfos());
-      // Extract all other MonitoringInfos other than the execution time monitoring infos.
+      // Extract MonitoringInfos that come from the metrics container registry.
       response.addAllMonitoringInfos(
           bundleProcessor.getMetricsContainerRegistry().getMonitoringInfos());
+      // Add any additional monitoring infos that the "runners" report explicitly.
+      for (ProgressRequestCallback progressRequestCallback :
+          bundleProcessor.getProgressRequestCallbacks()) {
+        response.addAllMonitoringInfos(progressRequestCallback.getMonitoringInfos());

Review comment:
       Progress metrics won't appear in the final monitoring infos since there are no active elements. Any residuals will contain their size if a sized SDF element and processing URN was used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org