You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Isaac Chiang <is...@gmail.com> on 2013/04/24 09:31:13 UTC
Re: Review Request: CLOUDSTACK-2132 : The reload button doesn't work with
Security Groups and Statistic tab in instance detail view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10751/
-----------------------------------------------------------
(Updated April 24, 2013, 7:31 a.m.)
Review request for cloudstack and Pranav Saxena.
Summary (updated)
-----------------
CLOUDSTACK-2132 : The reload button doesn't work with Security Groups and Statistic tab in instance detail view
Description
-------
The reload button for security group tab and statistic tab doesn't actually send a request to the back-end but use the data when the user clicking into the instances detail view.
The patch fix the issue that request to the server and replace the associated tab with lately returned data.
This addresses bug CLOUSTACK-2132.
Diffs
-----
ui/scripts/instances.js 3a43c60
Diff: https://reviews.apache.org/r/10751/diff/
Testing
-------
Test from UI and work as expect.
Thanks,
Isaac Chiang
Re: Review Request: CLOUDSTACK-2132 : The reload button doesn't work with
Security Groups and Statistic tab in instance detail view
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10751/#review20158
-----------------------------------------------------------
Ship it!
The problem was that the API call was not invoked (since UI did not trigger it)when clicking the Refresh button . The patch looks good and works . I'll merge it with master . Thanks Isaac for the patch .Good catch !
- Pranav Saxena
On April 24, 2013, 7:31 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10751/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 7:31 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> The reload button for security group tab and statistic tab doesn't actually send a request to the back-end but use the data when the user clicking into the instances detail view.
> The patch fix the issue that request to the server and replace the associated tab with lately returned data.
>
>
> This addresses bug CLOUSTACK-2132.
>
>
> Diffs
> -----
>
> ui/scripts/instances.js 3a43c60
>
> Diff: https://reviews.apache.org/r/10751/diff/
>
>
> Testing
> -------
>
> Test from UI and work as expect.
>
>
> Thanks,
>
> Isaac Chiang
>
>
Re: Review Request: CLOUDSTACK-2132 : The reload button doesn't work with
Security Groups and Statistic tab in instance detail view
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10751/#review20160
-----------------------------------------------------------
Patch has been merged with master - Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/63f3ccd4 . Please mark the review request as Submitted .
- Pranav Saxena
On April 24, 2013, 7:31 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10751/
> -----------------------------------------------------------
>
> (Updated April 24, 2013, 7:31 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> The reload button for security group tab and statistic tab doesn't actually send a request to the back-end but use the data when the user clicking into the instances detail view.
> The patch fix the issue that request to the server and replace the associated tab with lately returned data.
>
>
> This addresses bug CLOUSTACK-2132.
>
>
> Diffs
> -----
>
> ui/scripts/instances.js 3a43c60
>
> Diff: https://reviews.apache.org/r/10751/diff/
>
>
> Testing
> -------
>
> Test from UI and work as expect.
>
>
> Thanks,
>
> Isaac Chiang
>
>