You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/30 10:02:24 UTC
[GitHub] [incubator-doris] caoliang-web opened a new pull request, #9860: [test]Adding Window Funnel function causes be crash for regression test
caoliang-web opened a new pull request, #9860:
URL: https://github.com/apache/incubator-doris/pull/9860
## Problem Summary:
Adding Window Funnel function causes be crash for regression test
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caoliang-web closed pull request #9860: [test]Adding Window Funnel function causes be crash for regression test
Posted by GitBox <gi...@apache.org>.
caoliang-web closed pull request #9860: [test]Adding Window Funnel function causes be crash for regression test
URL: https://github.com/apache/incubator-doris/pull/9860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] carlvinhust2012 commented on a diff in pull request #9860: [test]Adding Window Funnel function causes be crash for regression test
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #9860:
URL: https://github.com/apache/incubator-doris/pull/9860#discussion_r884757113
##########
regression-test/suites/query/sql_functions/window_functions/test_window_funnel.groovy:
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_window_funnel", "query") {
+ // todo:test Window Funnel function causes be to crash
+ def tableName = "dev_windowfunnel_test2"
+
+ sql """ DROP TABLE IF EXISTS ${tableName} """
+
+ sql """ CREATE TABLE $tableName ( `xwho` varchar(50) NULL COMMENT 'xwho', `xwhen` datetime COMMENT 'xwhen', `xwhat` int NULL COMMENT 'xwhat' ) DUPLICATE KEY(xwho) DISTRIBUTED BY HASH(xwho) BUCKETS 3 PROPERTIES ( "replication_num" = "1" ); """
Review Comment:
Suggest a line break here，it's too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caoliang-web commented on a diff in pull request #9860: [test]Adding Window Funnel function causes be crash for regression test
Posted by GitBox <gi...@apache.org>.
caoliang-web commented on code in PR #9860:
URL: https://github.com/apache/incubator-doris/pull/9860#discussion_r884847262
##########
regression-test/suites/query/sql_functions/window_functions/test_window_funnel.groovy:
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_window_funnel", "query") {
+ // todo:test Window Funnel function causes be to crash
+ def tableName = "dev_windowfunnel_test2"
+
+ sql """ DROP TABLE IF EXISTS ${tableName} """
+
+ sql """ CREATE TABLE $tableName ( `xwho` varchar(50) NULL COMMENT 'xwho', `xwhen` datetime COMMENT 'xwhen', `xwhat` int NULL COMMENT 'xwhat' ) DUPLICATE KEY(xwho) DISTRIBUTED BY HASH(xwho) BUCKETS 3 PROPERTIES ( "replication_num" = "1" ); """
Review Comment:
ok, good suggestion, revised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org