You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "hofi1 (via GitHub)" <gi...@apache.org> on 2023/10/05 01:39:22 UTC
[I] flaky test assertions in org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment [helix]
hofi1 opened a new issue, #2640:
URL: https://github.com/apache/helix/issues/2640
### Describe the bug
The test org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment is flaky. The JSON strings in the assertion can change and sometime not pass the assertions.
### To Reproduce
mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment
### Expected behavior
Test should not be flaky – it should pass or fail (in the current case it should pass)
### Additional context
Change the assertions from JUNIT-Assertions to JSONAssertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [I] flaky test assertions in org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment [helix]
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue closed issue #2640: flaky test assertions in org.apache.helix.rest.server.TestResourceAssignmentOptimizerAccessor#testComputePartitionAssignment
URL: https://github.com/apache/helix/issues/2640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org