You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/11/07 20:08:53 UTC
Re: Review Request 40005: Added principal field to /master/framework
and /master/state endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40005/
-----------------------------------------------------------
(Updated Nov. 7, 2015, 7:08 p.m.)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Added principal field to /master/framework and /master/state endpoint.
Bugs: MESOS-3835
https://issues.apache.org/jira/browse/MESOS-3835
Repository: mesos
Description (updated)
-------
see summary.
Diffs
-----
src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d
Diff: https://reviews.apache.org/r/40005/diff/
Testing
-------
Ubuntu 14.04
make
make check
root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/state" 2>/dev/null| jq . | grep prin
"principal": "p1",
root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/frameworks" 2>/dev/null| jq . | grep prin
"principal": "p1",
Thanks,
Guangya Liu
Re: Review Request 40005: Added principal field to /master/framework
and /master/state endpoint.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40005/#review106139
-----------------------------------------------------------
can you rebase?
- Vinod Kone
On Nov. 7, 2015, 7:08 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40005/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 7:08 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3835
> https://issues.apache.org/jira/browse/MESOS-3835
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d
>
> Diff: https://reviews.apache.org/r/40005/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/state" 2>/dev/null| jq . | grep prin
> "principal": "p1",
> root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/frameworks" 2>/dev/null| jq . | grep prin
> "principal": "p1",
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40005: Added principal field to /master/framework
and /master/state endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40005/#review106196
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40005]
All tests passed.
- Mesos ReviewBot
On Nov. 12, 2015, 2:33 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40005/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 2:33 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3835
> https://issues.apache.org/jira/browse/MESOS-3835
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf
>
> Diff: https://reviews.apache.org/r/40005/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/state" 2>/dev/null| jq . | grep prin
> "principal": "p1",
> root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/frameworks" 2>/dev/null| jq . | grep prin
> "principal": "p1",
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40005: Added principal field to /master/framework
and /master/state endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40005/#review106197
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40005]
All tests passed.
- Mesos ReviewBot
On Nov. 12, 2015, 2:33 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40005/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 2:33 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3835
> https://issues.apache.org/jira/browse/MESOS-3835
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf
>
> Diff: https://reviews.apache.org/r/40005/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/state" 2>/dev/null| jq . | grep prin
> "principal": "p1",
> root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/frameworks" 2>/dev/null| jq . | grep prin
> "principal": "p1",
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40005: Added principal field to /master/framework
and /master/state endpoint.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40005/
-----------------------------------------------------------
(Updated εδΈζ 12, 2015, 2:33 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase
Bugs: MESOS-3835
https://issues.apache.org/jira/browse/MESOS-3835
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf
Diff: https://reviews.apache.org/r/40005/diff/
Testing
-------
Ubuntu 14.04
make
make check
root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/state" 2>/dev/null| jq . | grep prin
"principal": "p1",
root@devstack007:~/src/mesos/bug/mesos/build# curl "http://9.111.242.187:5050/master/frameworks" 2>/dev/null| jq . | grep prin
"principal": "p1",
Thanks,
Guangya Liu