You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ra0077 <gi...@git.apache.org> on 2016/08/05 13:12:56 UTC

[GitHub] jmeter pull request #224: Bug59948 html formated render

GitHub user ra0077 opened a pull request:

    https://github.com/apache/jmeter/pull/224

    Bug59948 html formated render

    Hi,
    In "View Results Tree" we can check the HTML source code with Text render.
    
    When the source code is not formated, it could be complex to read the source code.
    
    I propose to use Jsoup (already use in JMeter)to format/sane the HTML source code in a new render called HTML formated
    
    Antonio

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ra0077/jmeter Bug59948_HTMLFormatedRender

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit 8f1ca683d76a4bafb58c616777b3aefad7242449
Author: ra0077 <ra...@gmail.com>
Date:   2016-08-05T13:09:49Z

    Bug59948_HTMLFormatedRender
    
    In "View Results Tree" we can check the HTML source code with Text
    render.
    
    Some time (not formated source code) it could be complex to read the
    source code.
    
    I propose to use Jsoup (already use in JMeter)to format/sane the HTML
    source code in a new render called HTML formated
    
    Antonio

commit 6c65d94ce4e090fd5cc43a5e9f247e5ac6c7f33c
Author: ra0077 <ra...@gmail.com>
Date:   2016-08-05T13:11:49Z

    Add bug number in changes.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #224: Bug59948 html formated render

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/224
  
    +1 for commiting it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #224: Bug59948 html formated render

Posted by ubikloadpack <gi...@git.apache.org>.
Github user ubikloadpack commented on the issue:

    https://github.com/apache/jmeter/pull/224
  
    Hello,
    Thanks for PR.
    Wouldn't it be more user friendly to add a checkbox on the existing HTML viewer to format or not the HTML ?
    
    Regards
    @ubikloadpack


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #224: Bug59948 html formated render

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/224


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #224: Bug59948 html formated render

Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the issue:

    https://github.com/apache/jmeter/pull/224
  
    Hi,
    
    HTML render display the HTML and not the source code of HTML
    
    If we add a checkbox, it can be only for Text render (and not for the other)?
    
    In my opinion, it will be complex to add it in a beautiful/friendly way
    
    But if you have a good idea, please advice me
    
    Antonio



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #224: Bug59948 html formated render

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/224
  
    Yes you're correct, I meant Text renderer but in that case formatting does not really make sense as it can be anything (not only html)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---