You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 18:17:10 UTC

[GitHub] [arrow] ianmcook commented on a change in pull request #10190: ARROW-11515: [R] Bindings for strsplit

ianmcook commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r626002973



##########
File path: r/R/dplyr.R
##########
@@ -1099,3 +1126,12 @@ not_implemented_for_dataset <- function(method) {
     call. = FALSE
   )
 }
+
+#' Does this string contain regex metacharacters?
+#' 
+#' @param string String to be tested
+#' @keywords internal
+#' @return Logical: does `string` contain regex metacharacters?
+contains_regex <- function(string){
+  grepl("[.\\|()[{^$*+?]", string)
+}

Review comment:
       Nice! Please add a newline at the end of the file:
   ```suggestion
   }
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org