You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by tombentley <gi...@git.apache.org> on 2017/06/09 11:11:51 UTC

[GitHub] kafka pull request #3280: Avoid calling interceptors.onSendError() with null...

GitHub user tombentley opened a pull request:

    https://github.com/apache/kafka/pull/3280

    Avoid calling interceptors.onSendError() with null TopicPartition

    Assign non-null tp as soon as possible once we know the partition. This is
    so that if ensureValidRecordSize() throws, the
    interceptors.onSendError() call is made with a non-null tp.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tombentley/kafka tp-assign

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3280
    
----
commit addc648bb1d76d009573a2477ba6da09932c4322
Author: Tom Bentley <tb...@redhat.com>
Date:   2017-06-09T11:01:58Z

    Avoid calling interceptors.onSendError() with null TopicPartition
    
    Assign non-null tp as soon as possible once we know the partition. This is
    so that if ensureValidRecordSize() throws, the
    interceptors.onSendError() call is made with a non-null tp.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3280: MINOR: Avoid calling interceptors.onSendError() wi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3280


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---