You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/01/12 02:31:09 UTC
[PR] [SPARK-46692][BUILD][PYSPARK] Fix potential issues with environment variable transmission `PYTHON_TO_TEST` [spark]
panbingkun opened a new pull request, #44698:
URL: https://github.com/apache/spark/pull/44698
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1890179466
https://github.com/apache/spark/pull/44715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44698: [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps
URL: https://github.com/apache/spark/pull/44698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1891162709
> For them, let's skip it for now, and file a JIRA for each tests.
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD][PYSPARK] Fix potential issues with environment variable transmission `PYTHON_TO_TEST` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888340303
cc @HyukjinKwon @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Fix potential issues with environment variable transmission `PYTHON_TO_TEST` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888662831
After this PR is merged, I will observe whether the value of the environment variable 'PYTHON_TO_TEST' in steps `List Python packages (${{ env.PYTHON_TO_TEST }})`, `Upload test results to report` and `Upload unit tests log files` in `build_python` is normal at tomorrow morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Fix potential issues with environment variable transmission `PYTHON_TO_TEST` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888360932
For the sake of conservatism, we can fix this issue first, and then I will observe tomorrow's Has the environment variable for each step in Python been effective? If it is, we will bring back xxx.
For greater stability, we can fix this issue first, and then I will observe whether the environment variables `PYTHON_TO_TEST` for each step of `build_python` tomorrow are effective. If they are effective, we will bring `https://github.com/apache/spark/pull/44662` back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Fix potential issues with environment variable transmission `PYTHON_TO_TEST` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888363905
I found that in step `PySpark Run test`, it is used as follows:
https://github.com/panbingkun/spark/blob/efa891c4ea869a7fac58eabf187ac8aeff1fcd38/.github/workflows/build_and_test.yml#L446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888907465
Ya, +1 for the plan. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Fix potential environmental variable transfer issue in `pyspark job GA` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888838118
> Ya, this looks like the root causes.
>
> * Are these all instances?
> * Given that the change affects not only `PYTHON_TO_TEST`, but also all environment variables, please revise the PR title.
> > Fix potential issues with environment variable transmission PYTHON_TO_TEST
@dongjoon-hyun
Yes, in ' pyspark job GA', I checked and found that currently only these 3 steps are affected by this issue.
After this PR is merged, I will continue to observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1889544354
@dongjoon-hyun
Has the scheduling started yet? I have observed some errors in the `pypy3` environment, such as missing package: `grpc`. Is this expected?
https://github.com/apache/spark/actions/runs/7503864095/job/20429679584
<img width="957" alt="image" src="https://github.com/apache/spark/assets/15246973/a36a4910-2112-4979-adfb-8538b3ef491d">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "09306677806 (via GitHub)" <gi...@apache.org>.
09306677806 commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1890267451
0x161142F93e5Af29B51e7552AFbd84E1f563C8ee8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1890249874
> We should but I think that's not available. If grpc is not installed it should skip the tests properly.
Okay, let's continue to observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1890171935
We should but I think that's not available. If grpc is not installed it should skip the tests properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1888878352
> +1, LGTM.
@dongjoon-hyun
Thank you very much for giving this PR a suitable title. 😄
If tomorrow's scheduled task meets expectations, I will provide a PR to bring `https://github.com/apache/spark/pull/44662` back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1891153069
@HyukjinKwon
I have observed the following errors in the environment `pypy3`.
https://github.com/apache/spark/actions/runs/7519959346/job/20474204069
<img width="1008" alt="image" src="https://github.com/apache/spark/assets/15246973/3f95893e-422d-4ab6-bac9-abe9ed7d9d8f">
Do we need to install `pyarrow` in the environment? Or do we ignore some UT when we lack `pyarrow` again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1891159790
> pyarrow in PyPy isn't available up to my best knowledge.
I tried to install 'pyarrow' in pypy3 over the weekend, but one UT failed.
https://github.com/panbingkun/spark/actions/runs/7519505235/job/20468699700
<img width="1029" alt="image" src="https://github.com/apache/spark/assets/15246973/b263d00a-5f22-4778-91bb-10a1c3abbc70">
So should we ignore it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1891161456
For them, let's skip it for now, and file a JIRA for each tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46692][BUILD] Load `inputs.envs` always in `Python` and `Upload`-related steps [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44698:
URL: https://github.com/apache/spark/pull/44698#issuecomment-1891154899
pyarrow in PyPy isn't available up to my best knowledge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org