You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/09 03:19:41 UTC
[GitHub] [apisix-website] bzp2010 opened a new pull request #576: chore: bump docusaurus to 2.0beta6
bzp2010 opened a new pull request #576:
URL: https://github.com/apache/apisix-website/pull/576
Changes:
Upgrade docusaurus to over version 2.0.0-beta.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r706783010
##########
File path: website/package.json
##########
@@ -12,12 +12,18 @@
"docusaurus": "docusaurus"
},
"devDependencies": {
+ "@docusaurus/module-type-aliases": "^2.0.0-beta.6",
"@svgr/webpack": "^5.5.0",
- "babel-plugin-styled-components": "^1.12.0"
+ "@tsconfig/docusaurus": "^1.0.4",
+ "@types/react": "^17.0.20",
+ "@types/react-helmet": "^6.1.2",
+ "@types/react-router-dom": "^5.1.8",
+ "babel-plugin-styled-components": "^1.12.0",
+ "typescript": "^4.4.2"
},
"dependencies": {
- "@docusaurus/core": "2.0.0-beta.0",
- "@docusaurus/preset-classic": "2.0.0-beta.0",
+ "@docusaurus/core": "2.0.0-beta.6",
Review comment:
could it be possible for us use `^2.0.0-beta.6` then we can use the latest docusaurus every time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707014784
##########
File path: website/src/theme/DocSidebar/index.tsx
##########
@@ -0,0 +1,152 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
Review comment:
I don't know more information. Previous versions of this file have this header text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707020732
##########
File path: website/src/theme/DocSidebar/index.tsx
##########
@@ -0,0 +1,152 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
Review comment:
not for the header text, but for the whole file, Is it because docusaurus has upgrade the template itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707006569
##########
File path: website/package.json
##########
@@ -12,12 +12,18 @@
"docusaurus": "docusaurus"
},
"devDependencies": {
+ "@docusaurus/module-type-aliases": "^2.0.0-beta.6",
"@svgr/webpack": "^5.5.0",
- "babel-plugin-styled-components": "^1.12.0"
+ "@tsconfig/docusaurus": "^1.0.4",
+ "@types/react": "^17.0.20",
+ "@types/react-helmet": "^6.1.2",
+ "@types/react-router-dom": "^5.1.8",
+ "babel-plugin-styled-components": "^1.12.0",
+ "typescript": "^4.4.2"
},
"dependencies": {
- "@docusaurus/core": "2.0.0-beta.0",
- "@docusaurus/preset-classic": "2.0.0-beta.0",
+ "@docusaurus/core": "2.0.0-beta.6",
Review comment:
If there is a break change that will crash our CI, I recommend not using the latest version before the official version is launched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707018826
##########
File path: website/package.json
##########
@@ -12,12 +12,18 @@
"docusaurus": "docusaurus"
},
"devDependencies": {
+ "@docusaurus/module-type-aliases": "^2.0.0-beta.6",
"@svgr/webpack": "^5.5.0",
- "babel-plugin-styled-components": "^1.12.0"
+ "@tsconfig/docusaurus": "^1.0.4",
+ "@types/react": "^17.0.20",
+ "@types/react-helmet": "^6.1.2",
+ "@types/react-router-dom": "^5.1.8",
+ "babel-plugin-styled-components": "^1.12.0",
+ "typescript": "^4.4.2"
},
"dependencies": {
- "@docusaurus/core": "2.0.0-beta.0",
- "@docusaurus/preset-classic": "2.0.0-beta.0",
+ "@docusaurus/core": "2.0.0-beta.6",
Review comment:
got you, thanks @bzp2010 , then we need to keep an eye on the developments in the docusaurus community, we can follow the updates when it has important upgrades
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707006569
##########
File path: website/package.json
##########
@@ -12,12 +12,18 @@
"docusaurus": "docusaurus"
},
"devDependencies": {
+ "@docusaurus/module-type-aliases": "^2.0.0-beta.6",
"@svgr/webpack": "^5.5.0",
- "babel-plugin-styled-components": "^1.12.0"
+ "@tsconfig/docusaurus": "^1.0.4",
+ "@types/react": "^17.0.20",
+ "@types/react-helmet": "^6.1.2",
+ "@types/react-router-dom": "^5.1.8",
+ "babel-plugin-styled-components": "^1.12.0",
+ "typescript": "^4.4.2"
},
"dependencies": {
- "@docusaurus/core": "2.0.0-beta.0",
- "@docusaurus/preset-classic": "2.0.0-beta.0",
+ "@docusaurus/core": "2.0.0-beta.6",
Review comment:
If there is a destructive update that will crash our CI, I recommend not using the latest version before the official version is launched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707006569
##########
File path: website/package.json
##########
@@ -12,12 +12,18 @@
"docusaurus": "docusaurus"
},
"devDependencies": {
+ "@docusaurus/module-type-aliases": "^2.0.0-beta.6",
"@svgr/webpack": "^5.5.0",
- "babel-plugin-styled-components": "^1.12.0"
+ "@tsconfig/docusaurus": "^1.0.4",
+ "@types/react": "^17.0.20",
+ "@types/react-helmet": "^6.1.2",
+ "@types/react-router-dom": "^5.1.8",
+ "babel-plugin-styled-components": "^1.12.0",
+ "typescript": "^4.4.2"
},
"dependencies": {
- "@docusaurus/core": "2.0.0-beta.0",
- "@docusaurus/preset-classic": "2.0.0-beta.0",
+ "@docusaurus/core": "2.0.0-beta.6",
Review comment:
If there is a break change that will crash our CI, I recommend not using the latest version before the release version is launched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707112886
##########
File path: website/src/theme/DocSidebar/index.tsx
##########
@@ -0,0 +1,152 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
Review comment:
The reason is that this template used JavaScript before, but now it is implemented by TypeScript. After that, the remaining templates will be migrated to TypeScript. This will provide a better coding experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Baoyuantop commented on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917886947
> The mobile experience is better after the upgrade, and `back to top` button is also very useful.
>
> I noticed there is a little problem on css in blog page, we can create an issue after this pr got merged if there is nothing to modified. thanks
> 
It may be that some APIs have changed, I will pay attention to this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917933892
> The mobile experience is better after the upgrade, and `back to top` button is also very useful.
>
> I noticed there is a little problem on css in blog page, we can create an issue after this pr got merged if there is nothing to modified. thanks
Yes, this problem will be fixed in the following PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #576:
URL: https://github.com/apache/apisix-website/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707112886
##########
File path: website/src/theme/DocSidebar/index.tsx
##########
@@ -0,0 +1,152 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
Review comment:
The reason is that this template used JavaScript before, but now it is implemented by TypeScript. After that, the remaining templates will be migrated to TypeScript.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917852846
Here I provide a full preview address. The key modification is to add the mobile version sidebar adaptation and version selection on the document page.
[link here](https://upbeat-kare-734b69.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917635912
cc @qier222 to have a look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 edited a comment on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 edited a comment on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917852846
Hi @liuxiran @LiteSun @juzhiyuan,
Here I provide a full preview address. The key modification is to add the mobile version sidebar adaptation and version selection on the document page.
[link here](https://upbeat-kare-734b69.netlify.app)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917868201
The mobile experience is better after the upgrade, and `back to top` button is also very useful.
I noticed there is a little problem on css in blog page, we can create an issue after this pr got merged if there is nothing to modified. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r706778502
##########
File path: website/src/theme/DocSidebar/index.tsx
##########
@@ -0,0 +1,152 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
Review comment:
Hi @bzp2010 it seems that this file has been rewritten, would you please provide more details about this? thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#issuecomment-917579177
Hi @bzp2010 please fix the conflict file when you have time, thanks
also cc @qier222 @Baoyuantop @iamayushdas to have a review, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707105979
##########
File path: website/docusaurus.config.js
##########
@@ -241,7 +241,7 @@ module.exports = {
blog: {
path: "blog",
// see https://github.com/facebook/docusaurus/issues/5353
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #576: chore: bump docusaurus to 2.0beta6
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on a change in pull request #576:
URL: https://github.com/apache/apisix-website/pull/576#discussion_r707109619
##########
File path: website/docusaurus.config.js
##########
@@ -241,7 +241,7 @@ module.exports = {
blog: {
path: "blog",
// see https://github.com/facebook/docusaurus/issues/5353
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org