You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 00:39:02 UTC

[GitHub] [arrow] kou commented on a change in pull request #9157: ARROW-11204: [C++] Fix build failure with bundled gRPC and Protobuf on non MSVC

kou commented on a change in pull request #9157:
URL: https://github.com/apache/arrow/pull/9157#discussion_r554648227



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2460,15 +2466,9 @@ macro(build_grpc)
       -DgRPC_RE2_PROVIDER=package
       -DgRPC_SSL_PROVIDER=package
       -DgRPC_ZLIB_PROVIDER=package
-      -DgRPC_MSVC_STATIC_RUNTIME=${ARROW_USE_STATIC_CRT}
       -DCMAKE_INSTALL_PREFIX=${GRPC_PREFIX}
       -DCMAKE_INSTALL_LIBDIR=lib
       -DBUILD_SHARED_LIBS=OFF)
-  if(RE2_VENDORED)
-    list(APPEND GRPC_CMAKE_ARGS -Dre2_ROOT=${RE2_PREFIX}

Review comment:
       We can't use `<PackageName>_ROOT` with CMake 3.11 or older.
   (This is not related to MSVC.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org