You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2021/10/13 22:36:25 UTC
[royale-asjs] branch develop updated: 'mouseenter' and 'mouseleave'
are more correct here,
otherwise we have 'itemRollOver'/'itemRollOut' events triggering from child
elements of an item renderer,
which is wrong. Note: the goog.events.Event instances do not bubble even
though it seems clear from the code that this was the intention (the
bubbles 'true' argument does not make sense here for goog.events.Event). To
get bubbling working needs a switch to org.apache.royale.events.Event for
the 'itemRollOver'/'itemRollOut' events.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 6f7bb75 'mouseenter' and 'mouseleave' are more correct here, otherwise we have 'itemRollOver'/'itemRollOut' events triggering from child elements of an item renderer, which is wrong. Note: the goog.events.Event instances do not bubble even though it seems clear from the code that this was the intention (the bubbles 'true' argument does not make sense here for goog.events.Event). To get bubbling working needs a switch to org.apache.royale.events.Event for the 'itemRollOver'/'item [...]
6f7bb75 is described below
commit 6f7bb751ea9244c5202fb39d78cd0e8540be7f46
Author: greg-dove <gr...@gmail.com>
AuthorDate: Thu Oct 14 11:35:52 2021 +1300
'mouseenter' and 'mouseleave' are more correct here, otherwise we have 'itemRollOver'/'itemRollOut' events triggering from child elements of an item renderer, which is wrong.
Note: the goog.events.Event instances do not bubble even though it seems clear from the code that this was the intention (the bubbles 'true' argument does not make sense here for goog.events.Event). To get bubbling working needs a switch to org.apache.royale.events.Event for the 'itemRollOver'/'itemRollOut' events.
---
.../royale/html/beads/controllers/ItemRendererMouseController.as | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
index 199a676..7877d05 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/ItemRendererMouseController.as
@@ -92,8 +92,8 @@ package org.apache.royale.html.beads.controllers
COMPILE::JS {
var positioner:WrappedHTMLElement = (_strand as UIBase).positioner;
- goog.events.listen(positioner, goog.events.EventType.MOUSEOVER, this.handleMouseOver);
- goog.events.listen(positioner, goog.events.EventType.MOUSEOUT, this.handleMouseOut);
+ goog.events.listen(positioner, goog.events.EventType.MOUSEENTER, this.handleMouseOver);
+ goog.events.listen(positioner, goog.events.EventType.MOUSELEAVE, this.handleMouseOut);
goog.events.listen(positioner, goog.events.EventType.MOUSEDOWN, this.handleMouseDown);
goog.events.listen(positioner, goog.events.EventType.CLICK, this.handleMouseClick);
goog.events.listen(positioner, goog.events.EventType.MOUSEUP, this.handleMouseUp);