You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Mahler (Jira)" <ji...@apache.org> on 2020/05/01 22:12:00 UTC

[jira] [Commented] (MESOS-10093) Libprocess does not properly escape subprocess argument strings on Windows

    [ https://issues.apache.org/jira/browse/MESOS-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097699#comment-17097699 ] 

Benjamin Mahler commented on MESOS-10093:
-----------------------------------------

Cleanups have landed, I have to move on to other work, but here are two WIP patches of fixes at the stout and libprocess layer to make this easier when we pick this back up:

https://reviews.apache.org/r/72460/
https://reviews.apache.org/r/72461/

Also needed is a patch for Mesos in the docker wrapper code, and in the containerization launch related code. Then we need to document for users up in CommandInfo how shell=true and shell=false works for Windows in particular.

> Libprocess does not properly escape subprocess argument strings on Windows
> --------------------------------------------------------------------------
>
>                 Key: MESOS-10093
>                 URL: https://issues.apache.org/jira/browse/MESOS-10093
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>            Reporter: Greg Mann
>            Assignee: Benjamin Mahler
>            Priority: Major
>              Labels: containerization, docker, mesosphere, windows
>
> When running some tests of Mesos on Windows, I discovered that the following command would not execute successfully when passed to the Docker containerizer in {{TaskInfo.command}}:
> {noformat}
> python -c "print('hello world')"
> {noformat}
> The following error is found in the task sandbox:
> {noformat}
>   File "<string>", line 1
>     "print('hello
>                 ^
> SyntaxError: EOL while scanning string literal
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)