[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2165: Snapshot of APIs as of Apache NetBeans 12.0

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2165:
URL: https://github.com/apache/netbeans/pull/2165#discussion_r435788235



##########
File path: groovy/libs.gradle/nbproject/org-netbeans-modules-libs-gradle.sig
##########
@@ -0,0 +1,167 @@
+#Signature file v4.1
+#Version 6.3

Review comment:
       Looks like newly exported API from a library, right @lkishalmi?

##########
File path: java/junit/nbproject/org-netbeans-modules-junit.sig
##########
@@ -222,6 +245,14 @@ meth public static void logJUnitUsage(java.net.URI)
 supr java.lang.Object
 hfds foldersToSourceGroupsMap,javaSourceGroups,project,sourceGroupsOnly,sourcesToTestsMap
 
+CLSS public final !enum org.netbeans.modules.junit.api.JUnitVersion
+fld public final static org.netbeans.modules.junit.api.JUnitVersion JUNIT3
+fld public final static org.netbeans.modules.junit.api.JUnitVersion JUNIT4
+fld public final static org.netbeans.modules.junit.api.JUnitVersion JUNIT5

Review comment:
       I have opened this constants up when explicitly supporting JUnit 4.

##########
File path: java/dbschema/nbproject/org-netbeans-modules-dbschema.sig
##########
@@ -1635,7 +1635,7 @@ hfds bundle,con,dmd,driver,password,schema,url,username
 
 CLSS public org.netbeans.modules.dbschema.jdbcimpl.DBElementsCollection
 cons public init()
-fld protected static java.util.HashSet instances
+fld protected static java.util.Set<java.lang.String> instances

Review comment:
       Wow, this looks like an incompatible change, that sigtest forgot to report!

##########
File path: platform/libs.flatlaf/nbproject/org-netbeans-libs-flatlaf.sig
##########
@@ -59,6 +60,8 @@ supr com.formdev.flatlaf.FlatLightLaf
 
 CLSS public abstract com.formdev.flatlaf.FlatLaf
 cons public init()
+meth protected java.util.List<java.lang.Class<?>> getLafClassesForDefaultsLoading()
+meth protected java.util.Properties getAdditionalDefaults()

Review comment:
       Flat LaF changes.

##########
File path: ide/css.lib/nbproject/org-netbeans-modules-css-lib.sig
##########
@@ -1211,6 +1214,13 @@ meth public abstract boolean accepts(java.lang.String)
 meth public boolean accepts(org.netbeans.modules.css.lib.api.properties.Token)
 supr org.netbeans.modules.css.lib.api.properties.TokenAcceptor
 
+CLSS public static org.netbeans.modules.css.lib.api.properties.TokenAcceptor$Urange

Review comment:
       New public inner class.

##########
File path: java/maven/nbproject/org-netbeans-modules-maven.sig
##########
@@ -1346,6 +1346,8 @@ meth public static org.openide.WizardDescriptor$InstantiatingIterator<?> defined
  anno 4 org.netbeans.api.annotations.common.NullAllowed()
 meth public static org.openide.WizardDescriptor$InstantiatingIterator<?> definedArchetype(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
  anno 4 org.netbeans.api.annotations.common.NullAllowed()
+meth public static org.openide.WizardDescriptor$InstantiatingIterator<?> definedArchetype(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.util.Map<java.lang.String,java.lang.String>)
+ anno 4 org.netbeans.api.annotations.common.NullAllowed()

Review comment:
       Added when integrating JavaFX wizards, right @errael?

##########
File path: ide/gsf.testrunner/nbproject/org-netbeans-modules-gsf-testrunner.sig
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests getInputMethodRequests()
 meth public java.awt.image.ColorModel getColorModel()
 meth public java.awt.image.VolatileImage createVolatileImage(int,int)
 meth public java.awt.image.VolatileImage createVolatileImage(int,int,java.awt.ImageCapabilities) throws java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()

Review comment:
       Actually it would be better to remove all the `java.awt.peer.ComponentPeer getPeer()` occurences (manually). I have a feeling that the method has disappeared in JDK11 and as such, when one runs the sigtest on a new JDK, it fails saying that this method is missing. That is a false alarm.
   
   If possible, please remove all the 
   ```
   meth public java.awt.peer.ComponentPeer getPeer()
    anno 0 java.lang.Deprecated()
   ```
   occurrences before integrating.
   

##########
File path: java/java.source/nbproject/org-netbeans-modules-java-source.sig
##########
@@ -1265,6 +1267,7 @@ meth public static javax.lang.model.type.WildcardType resolveCapturedType(javax.
 meth public static org.netbeans.api.lexer.TokenSequence<org.netbeans.api.java.lexer.JavaTokenId> getJavaTokenSequence(org.netbeans.api.lexer.TokenHierarchy,int)
 meth public static org.openide.filesystems.FileObject getFile(javax.lang.model.element.Element,org.netbeans.api.java.source.ClasspathInfo)
 meth public static org.openide.filesystems.FileObject getFile(org.netbeans.api.java.source.ElementHandle<? extends javax.lang.model.element.Element>,org.netbeans.api.java.source.ClasspathInfo)
+meth public static void forceSource(org.netbeans.api.java.source.CompilationController,org.openide.filesystems.FileObject)

Review comment:
       Something @jlahoda shall check...

##########
File path: java/dbschema/nbproject/org-netbeans-modules-dbschema.sig
##########
@@ -2911,12 +2911,13 @@ meth public static void setDescriptionAsResource(org.openide.loaders.DataObject,
 meth public static void setIterator(org.openide.loaders.DataObject,org.openide.loaders.TemplateWizard$Iterator) throws java.io.IOException
  anno 0 java.lang.Deprecated()
 meth public void setTargetFolder(org.openide.loaders.DataFolder)
+meth public void setTargetFolderLazy(java.util.function.Supplier<org.openide.loaders.DataFolder>)

Review comment:
       I do remember this API change. Done by @errael, I think.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists