[GitHub] [nifi-minifi-cpp] apiri commented on a change in pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs

[GitBox <gi...@apache.org>]

apiri commented on a change in pull request #594: MINIFICPP-923: remove librdkafka, and deal with some bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/594#discussion_r293892192
 
 

 ##########
 File path: extensions/librdkafka/CMakeLists.txt
 ##########
 @@ -32,18 +30,42 @@ if(CMAKE_THREAD_LIBS_INIT)
   target_link_libraries(minifi-rdkafka-extensions "${CMAKE_THREAD_LIBS_INIT}")
 endif()
 
+  set(BASE_DIR "${CMAKE_CURRENT_BINARY_DIR}/thirdparty/kafka")
+  if (WIN32)
+  	set(BYPRODUCT "${BASE_DIR}/install/lib/librdkafka.lib")
+  else()
+  	set(BYPRODUCT "${BASE_DIR}/install/lib/librdkafka.a")
+  endif()
 
-# Include UUID
-find_package(UUID REQUIRED)
-target_link_libraries(minifi-rdkafka-extensions ${LIBMINIFI} ${UUID_LIBRARIES})
-target_link_libraries(minifi-rdkafka-extensions ${CMAKE_DL_LIBS} )
-if (LibRdKafka_FOUND AND NOT BUILD_LIBRDKAFKA)
-	target_link_libraries(minifi-rdkafka-extensions ${LibRdKafka_LIBRARIES} )
-else()
-	target_link_libraries(minifi-rdkafka-extensions rdkafka )
+list(APPEND CMAKE_MODULE_PATH_PASSTHROUGH_LIST "${CMAKE_SOURCE_DIR}/cmake/ssl")
+list(APPEND CMAKE_MODULE_PATH_PASSTHROUGH_LIST "${CMAKE_SOURCE_DIR}/cmake/zlib/dummy")
+    
+ExternalProject_Add(
+    kafka-external
+    GIT_REPOSITORY "https://github.com/edenhill/librdkafka.git"
+    GIT_TAG "v1.0.0" 
 
 Review comment:
   can we bump this to 1.0.1 (https://github.com/edenhill/librdkafka/releases/tag/v1.0.1)?  looks like a few other fixes made it in

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services