You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by sh...@apache.org on 2010/02/17 01:18:36 UTC

svn commit: r910782 - /qpid/trunk/qpid/cpp/src/CMakeLists.txt

Author: shuston
Date: Wed Feb 17 00:18:36 2010
New Revision: 910782

URL: http://svn.apache.org/viewvc?rev=910782&view=rev
Log:
Build the ACL source into the qpidbroker library on Windows; works around the problems with qmf-gen'd management code; see QPID-1842 for history.

Modified:
    qpid/trunk/qpid/cpp/src/CMakeLists.txt

Modified: qpid/trunk/qpid/cpp/src/CMakeLists.txt
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/CMakeLists.txt?rev=910782&r1=910781&r2=910782&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/CMakeLists.txt (original)
+++ qpid/trunk/qpid/cpp/src/CMakeLists.txt Wed Feb 17 00:18:36 2010
@@ -357,10 +357,6 @@
 
 # Build the ACL plugin
 set (acl_default ON)
-# Like this until we fix exporting symbols from the generated management code
-if (CMAKE_SYSTEM_NAME STREQUAL Windows)
-  set(acl_default OFF)
-endif (CMAKE_SYSTEM_NAME STREQUAL Windows)
 option(BUILD_ACL "Build ACL enforcement broker plugin" ${acl_default})
 if (BUILD_ACL)
   set (acl_SOURCES
@@ -372,17 +368,22 @@
        qpid/acl/AclReader.cpp
        qpid/acl/AclReader.h
       )
-  add_library (acl MODULE ${acl_SOURCES})
-  set_target_properties (acl PROPERTIES PREFIX "")
-  target_link_libraries (acl qpidbroker ${Boost_PROGRAM_OPTIONS_LIBRARY})
-  if (CMAKE_COMPILER_IS_GNUCXX)
-    set_target_properties (acl PROPERTIES
-                           PREFIX ""
-                           LINK_FLAGS -Wl,--no-undefined)
-  endif (CMAKE_COMPILER_IS_GNUCXX)
-  install (TARGETS acl
-           DESTINATION ${QPIDD_MODULE_DIR}
-           COMPONENT ${QPID_COMPONENT_BROKER})
+  # Windows builds the ACL code into the qpidbroker library; see QPID-1842
+  # for history and rationale. If this is changed, remove the acl_SOURCES from
+  # the qpidbroker platform-specific source list.
+  if (NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
+    add_library (acl MODULE ${acl_SOURCES})
+    set_target_properties (acl PROPERTIES PREFIX "")
+    target_link_libraries (acl qpidbroker ${Boost_PROGRAM_OPTIONS_LIBRARY})
+    if (CMAKE_COMPILER_IS_GNUCXX)
+      set_target_properties (acl PROPERTIES
+                             PREFIX ""
+                             LINK_FLAGS -Wl,--no-undefined)
+    endif (CMAKE_COMPILER_IS_GNUCXX)
+    install (TARGETS acl
+             DESTINATION ${QPIDD_MODULE_DIR}
+             COMPONENT ${QPID_COMPONENT_BROKER})
+  endif (NOT CMAKE_SYSTEM_NAME STREQUAL Windows)
 endif (BUILD_ACL)
 
 # Check for optional cluster support requirements
@@ -439,6 +440,7 @@
   set (qpidbroker_platform_SOURCES
     qpid/broker/windows/BrokerDefaults.cpp
     qpid/broker/windows/SaslAuthenticator.cpp
+    ${acl_SOURCES}
     ${sslbroker_windows_SOURCES}
   )
   set (qpidbroker_platform_LIBS



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org