You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2023/01/05 21:43:14 UTC
[GitHub] [hive] cnauroth opened a new pull request, #3918: HIVE-26910: Backport HIVE-19104: Use independent warehouse directories in test metastores.
cnauroth opened a new pull request, #3918:
URL: https://github.com/apache/hive/pull/3918
### What changes were proposed in this pull request?
`TestHS2ImpersonationWithRemoteMS` fails on branch-3. It makes assertions about the state of the warehouse directory, but it doesn't account for a part of metastore initialization that updates the warehouse directory to parameterize it by port number for test isolation.
`MetaStoreTestUtils#startMetaStoreWithRetry` sets the warehouse directory as the new `metastore.warehouse.dir` property. `AbstractHiveService#get/setWareHouseDir` later works with the deprecated `hive.metastore.warehouse.dir` property. `MetastoreConf` will take care of resolving requests for the new property to values under the old property, but not vice versa.
On master, [HIVE-19104](https://issues.apache.org/jira/browse/HIVE-19104) included an additional line in `MiniHs2` to make sure these 2 properties would stay in sync for test runs. This is a slightly modified backport of that patch to branch-3.
There is only one significant difference compared to the master patch. I needed to resolve a merge conflict in `WarehouseInstance`. This code is different on branch-3, because it clones a copy of the `HiveConf` before starting the metastore. (On master, it doesn't make a clone.) I traced this difference to [HIVE-19812](https://issues.apache.org/jira/browse/HIVE-19812), in which slightly different patches were committed to master and branch-3:
* master: 9bc90f28cf4406d74f9597837c2b72c809b582e6
* branch-3: 369798d90367187714ba68ff55784cff1342b020
Only the branch-3 patch had a `WarehouseInstance` change. I reviewed comments on HIVE-19812 / #365, but I couldn't find any record of why branch-3 needed this change. I have decided to preserve the behavior of cloning a copy.
### Why are the changes needed?
This patch is required as part of getting a clean CI run on branch-3 in preparation for a 3.2.0 release.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Without this patch, `TestHS2ImpersonationWithRemoteMS`fails locally. After applying the patch, the test passes. I also confirmed successful runs of all other test suites altered in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] cnauroth closed pull request #3918: HIVE-26910: Backport HIVE-19104: Use independent warehouse directories in test metastores.
Posted by GitBox <gi...@apache.org>.
cnauroth closed pull request #3918: HIVE-26910: Backport HIVE-19104: Use independent warehouse directories in test metastores.
URL: https://github.com/apache/hive/pull/3918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] cnauroth commented on pull request #3918: HIVE-26910: Backport HIVE-19104: Use independent warehouse directories in test metastores.
Posted by GitBox <gi...@apache.org>.
cnauroth commented on PR #3918:
URL: https://github.com/apache/hive/pull/3918#issuecomment-1372819245
> @amanraj2520 , FYI on a new branch-3 patch.
@amanraj2520 , Oops, sorry! I misunderstood. I see now that the changes are still included in your PR. I'll abandon my PR if yours gets committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] cnauroth commented on pull request #3918: HIVE-26910: Backport HIVE-19104: Use independent warehouse directories in test metastores.
Posted by GitBox <gi...@apache.org>.
cnauroth commented on PR #3918:
URL: https://github.com/apache/hive/pull/3918#issuecomment-1372814418
@amanraj2520 , FYI on a new branch-3 patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] cnauroth commented on pull request #3918: HIVE-26910: Backport HIVE-19104: Use independent warehouse directories in test metastores.
Posted by GitBox <gi...@apache.org>.
cnauroth commented on PR #3918:
URL: https://github.com/apache/hive/pull/3918#issuecomment-1372828318
Closing, as this is being done in #3873 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org