You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ga...@apache.org on 2019/01/18 12:52:27 UTC

[flink] 01/02: [hotfix][tests] Fix checkstyle violation and extract NoDataSource

This is an automated email from the ASF dual-hosted git repository.

gary pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 6516659e603939344d6d673f34e3e233ef7b7593
Author: Tzu-Li Chen <wa...@gmail.com>
AuthorDate: Wed Oct 24 23:41:27 2018 +0800

    [hotfix][tests] Fix checkstyle violation and extract NoDataSource
---
 .../java/org/apache/flink/yarn/NoDataSource.java   | 35 ++++++++++++++++++++++
 .../java/org/apache/flink/yarn/YARNITCase.java     | 12 --------
 .../apache/flink/yarn/YARNSessionFIFOITCase.java   |  1 +
 3 files changed, 36 insertions(+), 12 deletions(-)

diff --git a/flink-yarn-tests/src/test/java/org/apache/flink/yarn/NoDataSource.java b/flink-yarn-tests/src/test/java/org/apache/flink/yarn/NoDataSource.java
new file mode 100644
index 0000000..34d8d70
--- /dev/null
+++ b/flink-yarn-tests/src/test/java/org/apache/flink/yarn/NoDataSource.java
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.yarn;
+
+import org.apache.flink.streaming.api.functions.source.ParallelSourceFunction;
+
+/**
+ * Parallel data source that produces no data, i.e., finishes immediately.
+ */
+public class NoDataSource implements ParallelSourceFunction<Integer> {
+
+	private static final long serialVersionUID = 1642561062000662861L;
+
+	@Override
+	public void run(SourceContext<Integer> ctx) {}
+
+	@Override
+	public void cancel() {}
+}
diff --git a/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java b/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
index 7f9ea7e..4420f89 100644
--- a/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
+++ b/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
@@ -28,7 +28,6 @@ import org.apache.flink.runtime.jobgraph.JobGraph;
 import org.apache.flink.runtime.jobmaster.JobResult;
 import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
 import org.apache.flink.streaming.api.functions.sink.DiscardingSink;
-import org.apache.flink.streaming.api.functions.source.ParallelSourceFunction;
 import org.apache.flink.yarn.util.YarnTestUtils;
 
 import org.apache.hadoop.fs.Path;
@@ -123,15 +122,4 @@ public class YARNITCase extends YarnTestBase {
 			}
 		}
 	}
-
-	private static class NoDataSource implements ParallelSourceFunction<Integer> {
-
-		private static final long serialVersionUID = 1642561062000662861L;
-
-		@Override
-		public void run(SourceContext<Integer> ctx) {}
-
-		@Override
-		public void cancel() {}
-	}
 }
diff --git a/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java b/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
index fb2c6cc..f6e097f 100644
--- a/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
+++ b/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
@@ -29,6 +29,7 @@ import org.apache.flink.test.testdata.WordCountData;
 import org.apache.flink.test.util.SecureTestEnvironment;
 import org.apache.flink.yarn.cli.FlinkYarnSessionCli;
 import org.apache.flink.yarn.configuration.YarnConfigOptions;
+import org.apache.flink.yarn.util.YarnTestUtils;
 
 import org.apache.commons.io.FileUtils;
 import org.apache.hadoop.fs.Path;