You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/14 05:11:00 UTC

[jira] [Commented] (SCB-669) Fix List response body deserialization problem

    [ https://issues.apache.org/jira/browse/SCB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511992#comment-16511992 ] 

ASF GitHub Bot commented on SCB-669:
------------------------------------

yhs0092 opened a new pull request #768: [SCB-669] add extra hashcode into CtTypeJavaType to avoid deserialization problem
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/768
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   Add extra hashcode into CtTypeJavaType to fix list type response body deserialization problem.
   See details in [SCB-669](https://issues.apache.org/jira/browse/SCB-669)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix List response body deserialization problem
> ----------------------------------------------
>
>                 Key: SCB-669
>                 URL: https://issues.apache.org/jira/browse/SCB-669
>             Project: Apache ServiceComb
>          Issue Type: Bug
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>             Fix For: service-center-1.0.0-m2
>
>         Attachments: invokeProviderDirectly.jpg, invokeViaEdgeService.jpg
>
>
> When a provider has a rest operation whose response is List<Pack>, and the type Pack is like below
> {code:java}
> public class Pack{
>   private String name;
>   private int i;
>   // PackageProp is a type defined by user, and it only contains simple java type
>   private List<PackageProp> packagePropList;
> }
> public class PackageProp{
>   private String name;
>   private int j;
>   private String prop;
> }
> {code}
> We can use postman to invoke the rest operation directly and it works well. But if we invoke this operation via EdgeService, the response body will be deserialized in edge unproperly. The edge treat the response List<Pack> as List<PackageProp>.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)