You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/06 18:44:00 UTC

Review Request 54433: Added a UNSET_CLOEXEC child hook to subprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54433/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

Added a UNSET_CLOEXEC child hook to subprocess.


Diffs
-----

  3rdparty/libprocess/include/process/subprocess_base.hpp 0d9c74a7d01795868b06479c794b8b7521f9c973 
  3rdparty/libprocess/src/subprocess.cpp 340fc32bdffb083357a886ece31f1353885e8642 

Diff: https://reviews.apache.org/r/54433/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 54433: Added a UNSET_CLOEXEC child hook to subprocess.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54433/#review158274
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Dec. 6, 2016, 6:44 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54433/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a UNSET_CLOEXEC child hook to subprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess_base.hpp 0d9c74a7d01795868b06479c794b8b7521f9c973 
>   3rdparty/libprocess/src/subprocess.cpp 340fc32bdffb083357a886ece31f1353885e8642 
> 
> Diff: https://reviews.apache.org/r/54433/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>