You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ritwik Yadav <ri...@gmail.com> on 2015/02/04 01:24:47 UTC
Re: Review Request 30014: Enable the slave garbage collector to take
the number of links into account.
> On Jan. 22, 2015, 10:20 p.m., Mesos ReviewBot wrote:
> > Patch looks great!
> >
> > Reviews applied: [30015, 30014]
> >
> > All tests passed.
I was wondering if this review request was discarded? If yes, what would be a good alternate solution to the problem at hand?
- Ritwik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30014/#review69280
-----------------------------------------------------------
On Jan. 22, 2015, 9:35 p.m., Ritwik Yadav wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30014/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 9:35 p.m.)
>
>
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-391
> https://issues.apache.org/jira/browse/MESOS-391
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A fix to enable the slave garbage collector to take the number of hard links (st_nlinks) into account when creating new directories.
>
> [UPDATE] - Distributed the changes into two review requests as per information posted by the Mesos ReviewBot.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794
> src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6
> src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9
> src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
>
> Diff: https://reviews.apache.org/r/30014/diff/
>
>
> Testing
> -------
>
> Mesos builds sucessfully and all existing tests pass.
>
>
> Thanks,
>
> Ritwik Yadav
>
>