You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2014/11/19 20:45:39 UTC
svn commit: r1640623 - in /lucene/dev/trunk/solr: CHANGES.txt
core/src/java/org/apache/solr/core/SolrResourceLoader.java
Author: markrmiller
Date: Wed Nov 19 19:45:39 2014
New Revision: 1640623
URL: http://svn.apache.org/r1640623
Log:
SOLR-3774: Solr adds RequestHandler SolrInfoMBeans twice to the JMX server.
Modified:
lucene/dev/trunk/solr/CHANGES.txt
lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1640623&r1=1640622&r2=1640623&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Wed Nov 19 19:45:39 2014
@@ -291,6 +291,9 @@ Bug Fixes
* SOLR-6738: Admin UI - Escape Data on Plugins-View (steffkes)
+* SOLR-3774: Solr adds RequestHandler SolrInfoMBeans twice to the JMX server.
+ (Tomás Fernández Löbbe, hossman, Mark Miller)
+
Optimizations
----------------------
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java?rev=1640623&r1=1640622&r2=1640623&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java Wed Nov 19 19:45:39 2014
@@ -695,10 +695,14 @@ public class SolrResourceLoader implemen
for (SolrInfoMBean bean : arr) {
- try {
- infoRegistry.put(bean.getName(), bean);
- } catch (Exception e) {
- log.warn("could not register MBean '" + bean.getName() + "'.", e);
+ // Too slow? I suspect not, but we may need
+ // to start tracking this in a Set.
+ if (!infoRegistry.containsValue(bean)) {
+ try {
+ infoRegistry.put(bean.getName(), bean);
+ } catch (Exception e) {
+ log.warn("could not register MBean '" + bean.getName() + "'.", e);
+ }
}
}
}