You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Darryl L. Pierce (JIRA)" <ji...@apache.org> on 2012/10/02 22:05:07 UTC
[jira] [Created] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Darryl L. Pierce created PROTON-48:
--------------------------------------
Summary: Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
Key: PROTON-48
URL: https://issues.apache.org/jira/browse/PROTON-48
Project: Qpid Proton
Issue Type: Improvement
Components: proton-c
Reporter: Darryl L. Pierce
Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Stitcher reopened PROTON-48:
-----------------------------------
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Pierce updated PROTON-48:
-----------------------------------
Attachment: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafael H. Schloming resolved PROTON-48.
---------------------------------------
Resolution: Fixed
Applied patch modulo fixing one forgotten QPID_
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR
macro to the Cmake environment
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475144#comment-13475144 ]
Darryl L. Pierce edited comment on PROTON-48 at 10/12/12 4:48 PM:
------------------------------------------------------------------
Rafi, I wasn't aware of the LIBDIR macro in Cmake. This patch was based on a similar macro in Qpid named QPID_INSTALL_LIBDIR.
was (Author: mcpierce):
Rafi, I wasn't aware of the LIBDIR macro in Cmake.
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR
macro to the Cmake environment
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475059#comment-13475059 ]
Andrew Stitcher edited comment on PROTON-48 at 10/12/12 3:13 PM:
-----------------------------------------------------------------
Ok I see what the patch adds - reworked to more sanely switch from $PREFIX/lib to $PREFIX/<whatever you want>
[Note though that specifying LIBDIR directly might be more useful than just the directory name as I think the packaging environment can supply it directly through the __libdir macro, which would automatically be sent into configure, but will have to be sent manually into cmake - at least that's my understanding of how rpmbuild works. If this is so then both changes can be backed out]
was (Author: astitcher):
Ok I see what the patch adds - reworked to more sanely switch from $PREFIX/lib to $PREFIX/<whatever you want>
[Note though that specifying LIBDIR directly might be more useful than just the directory name as I think the packaging environment can supply it directly through the __libdir macro, which would automatically be sent into configure, but will have to be sent manually into cmake - at least that's my understanding of how rpmbuild works]
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Darryl L. Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475144#comment-13475144 ]
Darryl L. Pierce commented on PROTON-48:
----------------------------------------
Rafi, I wasn't aware of the LIBDIR macro in Cmake.
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475059#comment-13475059 ]
Andrew Stitcher commented on PROTON-48:
---------------------------------------
Ok I see what the patch adds - reworked to more sanely switch from $PREFIX/lib to $PREFIX/<whatever you want>
[Note though that specifying LIBDIR directly might be more useful than just the directory name as I think the packaging environment can supply it directly through the __libdir macro, which would automatically be sent into configure, but will have to be sent manually into cmake - at least that's my understanding of how rpmbuild works]
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475044#comment-13475044 ]
Rafael H. Schloming commented on PROTON-48:
-------------------------------------------
I didn't really think too hard when applying it, but you raise a good point. Darryl? What's the benefit of overriding PROTON_BLAH instead of just overriding LIBDIR directly?
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro
to the Cmake environment
Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475025#comment-13475025 ]
Andrew Stitcher commented on PROTON-48:
---------------------------------------
This is a completely unnecessary patch you can already specify the name of the lib directory that's the entire purpose of the LIBDIR setting - I don't understand what this extra code adds.
Unless I get a cinvincing response I'll revert the this patch.
> Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
> -------------------------------------------------------------
>
> Key: PROTON-48
> URL: https://issues.apache.org/jira/browse/PROTON-48
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Darryl L. Pierce
> Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch
>
>
> On 64-bit platforms, the libraries need to be installed into a directory named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets the build environment specify the directory name, with the default behavior being what CMake already does it the directory isn't specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira