You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/08 06:58:42 UTC

[GitHub] [airflow] jacobhjkim opened a new issue #15269: Update GoogleAdsHook to authenticate via OAuth2

jacobhjkim opened a new issue #15269:
URL: https://github.com/apache/airflow/issues/15269


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   **Description**
   Currently, GoogleAdsHook only supports the `service account authentication flow`. It would be nice to have a way to authenticate with `OAuth2 installed application flow`.
   <!-- A short description of your feature -->
   
   **Use case / motivation**
   [AdWords API Doc](https://developers.google.com/adwords/api/docs/guides/authentication#an_alternative_to_service_accounts) 
   > Because of the complexity of setting up service account access for the AdWords API, we recommend a simpler alternative that achieves the same goal, which is to use the OAuth2 installed application flow
   
   To quote Google, service account flow is a hassle, and they recommend `OAuth2 installed application flow`. With this feature, GoogleAds operator users will be able to choose which authentication flow to use.
   
   <!-- What do you want to happen?
   
   Rather than telling us how you might implement this solution, try to take a
   step back and describe what you are trying to achieve.
   
   -->
   
   **Are you willing to submit a PR?**
   Yes!
   
   <!--- We accept contributions! -->
   
   **Related Issues**
   AIRFLOW-6732
   
   <!-- Is there currently another issue associated with this? -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #15269: Update GoogleAdsHook to authenticate via OAuth2

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15269:
URL: https://github.com/apache/airflow/issues/15269#issuecomment-915977931


   @jacobhjkim are you still working on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jacobhjkim commented on issue #15269: Update GoogleAdsHook to authenticate via OAuth2

Posted by GitBox <gi...@apache.org>.
jacobhjkim commented on issue #15269:
URL: https://github.com/apache/airflow/issues/15269#issuecomment-915979088


   I'm not working on this issue. I think we can close it for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jacobhjkim closed issue #15269: Update GoogleAdsHook to authenticate via OAuth2

Posted by GitBox <gi...@apache.org>.
jacobhjkim closed issue #15269:
URL: https://github.com/apache/airflow/issues/15269


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #15269: Update GoogleAdsHook to authenticate via OAuth2

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15269:
URL: https://github.com/apache/airflow/issues/15269#issuecomment-816797938


   @jacobhjkim assigned to you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org