You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/05/11 13:22:20 UTC
[PR] fix(ux): remove CSS-forced uppercase from button labels [superset]
aminghadersohi opened a new pull request, #40021:
URL: https://github.com/apache/superset/pull/40021
### SUMMARY
Two styled button components in the deck.gl/map controls were using `text-transform: uppercase` in their CSS, which forced button labels to ALL CAPS. This is inconsistent with the rest of the Superset design system where buttons render in their natural casing.
Removed `text-transform: uppercase` from:
- `StyledCloseButton` in `LayerConfigsPopoverContent.tsx`
- `StyledSaveButton` in `LayerConfigsPopoverContent.tsx`
- `StyledExtentButton` in `MapViewControl.tsx`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Button labels like "Save" and "Close" appeared as "SAVE" and "CLOSE"
After: Button labels render in their natural casing as provided by the component
### TESTING INSTRUCTIONS
1. Open a dashboard with a deck.gl map chart
2. Open the layer configuration popover
3. Verify the "Save" and "Close" buttons render in natural casing (not ALL CAPS)
4. Open the map view control popover
5. Verify the extent button renders in natural casing
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ux): remove CSS-forced uppercase from button labels [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40021:
URL: https://github.com/apache/superset/pull/40021#issuecomment-4421089240
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ux): remove CSS-forced uppercase from button labels [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #40021:
URL: https://github.com/apache/superset/pull/40021#issuecomment-4430204118
Closing to reopen under the correct author (kasiazjc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ux): remove CSS-forced uppercase from button labels [superset]
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc closed pull request #40021: fix(ux): remove CSS-forced uppercase from button labels
URL: https://github.com/apache/superset/pull/40021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org