You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/06/22 21:34:45 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9591: syslog: Add sc_write_force callback

pkarashchenko commented on code in PR #9591:
URL: https://github.com/apache/nuttx/pull/9591#discussion_r1239049382


##########
drivers/syslog/syslog_flush.c:
##########
@@ -64,6 +64,7 @@
 
 int syslog_flush(void)
 {
+  FAR struct syslog_channel_s *channel;

Review Comment:
   ```suggestion
   ```



##########
drivers/syslog/syslog_flush.c:
##########
@@ -76,16 +77,17 @@ int syslog_flush(void)
 
   for (i = 0; i < CONFIG_SYSLOG_MAX_CHANNELS; i++)
     {
-      if (g_syslog_channel[i] == NULL)
+      channel = g_syslog_channel[i];

Review Comment:
   ```suggestion
         FAR struct syslog_channel_s *channel = g_syslog_channel[i];
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org