[GitHub] [flink] Aitozi commented on a change in pull request #17398: [FLINK-24357][tests] Harden ZooKeeperLeaderElectionConnectionHandlingTest

[GitBox <gi...@apache.org>]

Aitozi commented on a change in pull request #17398:
URL: https://github.com/apache/flink/pull/17398#discussion_r721118637



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/ZooKeeperLeaderElectionConnectionHandlingTest.java
##########
@@ -131,7 +130,8 @@ private void runTestWithZooKeeperConnectionProblem(
             Problem problem)
             throws Exception {
         CuratorFramework client =
-                ZooKeeperUtils.startCuratorFramework(configuration, NoOpFatalErrorHandler.INSTANCE);
+                ZooKeeperUtils.startCuratorFramework(
+                        configuration, fatalErrorHandlerResource.getFatalErrorHandler());

Review comment:
       +1 for this. 
   BTW,  I found that after removing the unhandled error listener in `LeaderElectionDriver` and `LeaderRetrievalDriver`. Some behavior of client created by using `NoOpFatalErrorHandler.INSTANCE` in test may be mute (without triggering fatal error setting in `TestingContender`). I will look over this again




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org