You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Jeremy Boynes (JIRA)" <de...@db.apache.org> on 2004/11/21 20:03:34 UTC

[jira] Created: (DERBY-73) Ability to compile under JDK1.5

Ability to compile under JDK1.5
-------------------------------

         Key: DERBY-73
         URL: http://nagoya.apache.org/jira/browse/DERBY-73
     Project: Derby
        Type: Improvement
  Components: Build tools  
    Reporter: Jeremy Boynes


Compilation fails when using JDK1.5 due to
1) no specification of language level
2) use of "enum" as identifier

The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.

Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-73) Ability to compile under JDK1.5

Posted by "Jeremy Boynes (JIRA)" <de...@db.apache.org>.
     [ http://nagoya.apache.org/jira/browse/DERBY-73?page=history ]

Jeremy Boynes updated DERBY-73:
-------------------------------

    Attachment: derby_jdk15_build2.patch

I was originally concerned about defaulting the code version levels and thought it would be better set in ~/ant.propeties.

Attached is a patch that sets the versions in modern.properties and reapplies the build.xml changes. I am not able to test with Jikes.

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://nagoya.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-73) Ability to compile under JDK1.5

Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
     [ http://nagoya.apache.org/jira/browse/DERBY-73?page=comments#action_56807 ]
     
Daniel John Debrunner commented on DERBY-73:
--------------------------------------------

Applied the part of the patch that fixed the enum name use.

Had trouble applying all the portions of the patch related to the build.xml files. Managed to patch most of the build.xml files, but then my build seemed to fail because, derby.compile.source and derby.compile.target were not set. Might need to ensure these are set by default otherwise applying this patch will break everyone's build. Maybe I just missed something obvious?


Sending        java\engine\org\apache\derby\iapi\store\access\RowUtil.java
Sending        java\engine\org\apache\derby\impl\sql\catalog\DataDictionaryImpl.java
Sending        java\engine\org\apache\derby\impl\sql\compile\FromBaseTable.java
Sending        java\engine\org\apache\derby\impl\sql\compile\FromList.java
Sending        java\engine\org\apache\derby\impl\sql\compile\FromTable.java
Sending        java\engine\org\apache\derby\impl\sql\depend\BasicDependencyManager.java
Sending        java\engine\org\apache\derby\impl\sql\execute\InternalTriggerExecutionContext.java
Sending        java\engine\org\apache\derby\impl\sql\execute\rts\RealBasicNoPutResultSetStatistics.java
Sending        java\engine\org\apache\derby\jdbc\EmbedPooledConnection.java
Sending        java\tools\org\apache\derby\impl\tools\ij\AttributeHolder.java
Sending        java\tools\org\apache\derby\impl\tools\ij\ConnectionEnv.java
Sending        java\tools\org\apache\derby\tools\URLCheck.java
Transmitting file data ............
Committed revision 122617.

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://nagoya.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-73) Ability to compile under JDK1.5

Posted by "Jeremy Boynes (JIRA)" <de...@db.apache.org>.
     [ http://nagoya.apache.org/jira/browse/DERBY-73?page=history ]

Jeremy Boynes updated DERBY-73:
-------------------------------

    Attachment: derby_jdk15_build.patch

Adds derby.compile.source and derby.compile.target parameters to force the language level used by javac
These can be specified in ${user.home}/ant.properties

Changes the name of "enum" variables to "e"

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://nagoya.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-73) Ability to compile under JDK1.5

Posted by "Heikki Linnakangas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-73?page=comments#action_12359473 ] 

Heikki Linnakangas commented on DERBY-73:
-----------------------------------------

JavaCC version 3.2 changes the variable name from "enum" to "e". It's The javacc.jar in tools/java should be upgraded.

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://issues.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-73) Ability to compile under JDK1.5

Posted by "Samuel Andrew McIntyre (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-73?page=comments#action_57994 ]
     
Samuel Andrew McIntyre commented on DERBY-73:
---------------------------------------------

DERBY-112 is probably a duplicate of this issue. Please comment if there is additional work to be done on this issue.

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://issues.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-73) Ability to compile under JDK1.5

Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-73?page=all ]

Andrew McIntyre updated DERBY-73:
---------------------------------

    Attachment: javacc40.diff

Patch with necessary changes for building with JavaCC 4.0. OPTIMIZE_TOKEN_MANAGER is no longer a supported option, and the generated code for mtGrammar includes a catch block for RuntimeException which uses a new method in RuntimeException introduced in JDK 1.4, so it became necessary to move the compilation of mtGrammar.java into the impl_tools_jdk14 target.

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://issues.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch, javacc40.diff
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-73) Ability to compile under JDK1.5

Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-73?page=comments#action_12367617 ] 

Andrew McIntyre commented on DERBY-73:
--------------------------------------

JavaCC 3.2 has an issue with lookahead that causes a failure in the test lang/db2compatibility.sql.

However, I have tried the recently released JavaCC 4.0, and it fixes that issue and all tests passed cleanly, so at some point we will likely upgrade to that version.

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://issues.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement
>   Components: Build tools
>     Reporter: Jeremy Boynes
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DERBY-73) Ability to compile under JDK1.5

Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-73?page=all ]
     
Andrew McIntyre closed DERBY-73:
--------------------------------


> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://issues.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement

>   Components: Build tools
>     Reporter: Jeremy Boynes
>     Assignee: Andrew McIntyre
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch, javacc40.diff
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (DERBY-73) Ability to compile under JDK1.5

Posted by "Andrew McIntyre (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-73?page=all ]
     
Andrew McIntyre resolved DERBY-73:
----------------------------------

    Resolution: Fixed
     Assign To: Andrew McIntyre

Fixed by changes to DERBY-1078

> Ability to compile under JDK1.5
> -------------------------------
>
>          Key: DERBY-73
>          URL: http://issues.apache.org/jira/browse/DERBY-73
>      Project: Derby
>         Type: Improvement

>   Components: Build tools
>     Reporter: Jeremy Boynes
>     Assignee: Andrew McIntyre
>  Attachments: derby_jdk15_build.patch, derby_jdk15_build2.patch, javacc40.diff
>
> Compilation fails when using JDK1.5 due to
> 1) no specification of language level
> 2) use of "enum" as identifier
> The language issue results in the use of the new StringBuilder class for string concatenation resulting in code that will not run on earlier JVMs.
> Dropping the langauge level will allow it to compile but warnings are generated due to the use of "enum" as an identifier; with 1.5 this becomes a reserved word

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira