Re: svn commit: rev 3813 - trunk/subversion/libsvn_subr

[br...@xbc.nu]

Quoting philip@tigris.org:

> Author: philip
> Date: 2002-11-17 07:12:25 -0600 (Sun, 17 Nov 2002)
> New Revision: 3813
[snip]
> * subversion/libsvn_subr/config_file.c (svn_config__user_config_path,
>   svn_config__sys_config_path): Canonicalize the base path.

This won't work in the Windows case. The path that svn_config__win_config_path
returns is not just not canonicalized, it's in the local encoding and style.
Which is wrong, of course, and needs to be fixed -- but not like this. I have to
fix that as part of issue 872.

    Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3813 - trunk/subversion/libsvn_subr

[Philip Martin <ph...@codematters.co.uk>]

brane@xbc.nu writes:

> > * subversion/libsvn_subr/config_file.c (svn_config__user_config_path,
> >   svn_config__sys_config_path): Canonicalize the base path.
> 
> This won't work in the Windows case. The path that svn_config__win_config_path
> returns is not just not canonicalized, it's in the local encoding and style.

Is it actively harmful?  The canonicalization just removes trailing
'/' and '.' characters.  Hmmm, when you say local encoding, do you
mean some sort of multi-byte encoding?  I guess that could break :-/

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org