You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/06/23 18:30:34 UTC
[I] refactor: remove the dead reflection fallback in orphan-cleanup walkDirectory [iceberg-go]
laskoviymishka opened a new issue, #1276:
URL: https://github.com/apache/iceberg-go/issues/1276
Follow-up to #916.
`walkDirectory` first tries `fsys.(iceio.ListableIO)` and returns immediately if it matches, then falls through to a `switch` with a `LocalFS` case and a blob `default` that calls `getBucketName`, which reaches into the FS with `reflect` to pull a `Bucket` field. Every concrete IO now implements `WalkDir` / `ListableIO` — `LocalFS`, `blobFileIO` (all gocloud constructors return it), and `MemFS` — so the `ListableIO` branch always wins and the switch plus `getBucketName` can never run. The thread asked to remove this once #917 landed; #917 is merged.
Delete the post-`ListableIO` fallback and `getBucketName` from `walkDirectory`, return an error if a non-`ListableIO` ever shows up, and drop the now-unused `reflect` import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] refactor: remove the dead reflection fallback in orphan-cleanup walkDirectory [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka closed issue #1276: refactor: remove the dead reflection fallback in orphan-cleanup walkDirectory
URL: https://github.com/apache/iceberg-go/issues/1276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org