You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/12 15:06:15 UTC
Review Request 46083: Used already forward-declared process::http::OK.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46083/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
Bugs: MESOS-5152
https://issues.apache.org/jira/browse/MESOS-5152
Repository: mesos
Description
-------
If we would e.g., make definitions in `mesos::http` visible using
`http::OK` in a test would look for `OK` in `mesos::http` instead of
the intended `process::http`.
Diffs
-----
src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
Diff: https://reviews.apache.org/r/46083/diff/
Testing
-------
make check (clang, w/o optimization, OS X)
Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp` leads to a compilation failure.
Thanks,
Benjamin Bannier
Re: Review Request 46083: Used already forward-declared
process::http::OK.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46083/#review128395
-----------------------------------------------------------
Can you please improve the **Description** field, I find it very hard to understand (removing it altogether is an option too).
- Alexander Rojas
On April 12, 2016, 3:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46083/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 3:06 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If we would e.g., make definitions in `mesos::http` visible using
> `http::OK` in a test would look for `OK` in `mesos::http` instead of
> the intended `process::http`.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46083/diff/
>
>
> Testing
> -------
>
> make check (clang, w/o optimization, OS X)
>
> Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp` leads to a compilation failure.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46083: Used already forward-declared
process::http::OK.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46083/#review128866
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 12, 2016, 6:48 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46083/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 6:48 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46083/diff/
>
>
> Testing
> -------
>
> make check (clang, w/o optimization, OS X)
>
> Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp` leads to a compilation failure.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46083: Used already forward-declared
process::http::OK.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46083/#review128400
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On April 12, 2016, 1:48 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46083/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 1:48 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
>
>
> Bugs: MESOS-5152
> https://issues.apache.org/jira/browse/MESOS-5152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
>
> Diff: https://reviews.apache.org/r/46083/diff/
>
>
> Testing
> -------
>
> make check (clang, w/o optimization, OS X)
>
> Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp` leads to a compilation failure.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46083: Used already forward-declared
process::http::OK.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46083/
-----------------------------------------------------------
(Updated April 12, 2016, 3:48 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Joerg Schad.
Changes
-------
Clarified description.
Bugs: MESOS-5152
https://issues.apache.org/jira/browse/MESOS-5152
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
src/tests/slave_tests.cpp 4a576b98d1cc58072626ac2c41c599bd3c8385c5
Diff: https://reviews.apache.org/r/46083/diff/
Testing
-------
make check (clang, w/o optimization, OS X)
Without this patch including e.g., `mesos/authentication/http/basic_authenticator_factory.hpp` leads to a compilation failure.
Thanks,
Benjamin Bannier