You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Divesh Dutta (JIRA)" <ji...@apache.org> on 2009/11/13 17:51:39 UTC
[jira] Created: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
---------------------------------------------------------------------------------------------------
Key: OFBIZ-3194
URL: https://issues.apache.org/jira/browse/OFBIZ-3194
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Fix For: SVN trunk
Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
{<#if listSize gt 20>}
This can be changed to
{<#if listSize gt viewSize>}
as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-3194.
------------------------------------
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778007#action_12778007 ]
Jacques Le Roux commented on OFBIZ-3194:
----------------------------------------
Bruno,
Is this value (20) not dependend of widget.form.defaultViewSize in widget.properties ?
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778063#action_12778063 ]
Bruno Busco commented on OFBIZ-3194:
------------------------------------
I retrieved from the ML the original use-case that was causing the problem:
"It seems that with a view-size less than 20 (eg: 5), and only 19 results (ie between view-size and 20), there will be no prev/next stuff."
The problem is originated IMO from a view-size that is not in the list of availableViewSizes.
In this case the property could be something like this:
widget.form.availableViewSizes=[5, 20, 30, 50, 100, 200];
widget.form.defaultViewSize = 5;
and the suggested code will work!
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778067#action_12778067 ]
Bruno Busco commented on OFBIZ-3194:
------------------------------------
I have seen that in UtilMisc.java there is a Method that retrieves the availableLocales with a public static List<Locale> availableLocales()
These are in a property like this: locales.available=en,fr,nl
Should we think to something similar for availableViewSizes ?
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-3194:
-------------------------------
Fix Version/s: (was: SVN trunk)
Release Candidate Branch 10.04
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: Release Candidate Branch 10.04
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778061#action_12778061 ]
Bruno Busco commented on OFBIZ-3194:
------------------------------------
Jacques,
in the renderNextPrev there is an hardcoded list of possible viewSize values; at the moment it is [20, 30, 50, 100, 200].
The correct change would be IMO:
1) Have this list specified as a property setting in addition to the actual defaultViewSize (i.e. adding something like widget.form.availableViewSizes = [20, 30, 50, 100, 200]
2) Replace the value 20 in the comparison (the one that has now been replaced with viewSize) with availableViewSizes[0]
Doing this we vill have the next/prev rendering in any case the number of the elements in the list is greater of the minimum number of elements the user can select to be shown.
Is it possible to have a list value for a property? Any pointer to a similar use?
Does this suggested logic solve the issue that has been reported?
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-3194:
--------------------------------
Attachment: OFBiz-3194.patch
Here is the path for the same.
Avoiding hard-code value and using viewSize instead. This was blocking to show all the products in "Quick look up" while placing purchase order
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Divesh Dutta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Divesh Dutta updated OFBIZ-3194:
--------------------------------
Component/s: (was: order)
framework
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777694#action_12777694 ]
Jacques Le Roux commented on OFBIZ-3194:
----------------------------------------
Then we should reopen, isn'it ?
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato resolved OFBIZ-3194.
--------------------------------------
Resolution: Fixed
Thank you Divesh,
your code is in rev. 835925
Jacopo
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-3194:
----------------------------------------
Assignee: Jacopo Cappellato
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco reopened OFBIZ-3194:
--------------------------------
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778081#action_12778081 ]
Jacques Le Roux commented on OFBIZ-3194:
----------------------------------------
Hi Bruno,
I did not look into details but this look like a good idea, if it does not break anything...
Also if we could use a default and let the user choice his/her own, as inititally Adrian suggested...
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3194) Quick look are showing pagination
renderNextPrev pagination style when list size is greater than 20
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777683#action_12777683 ]
Bruno Busco commented on OFBIZ-3194:
------------------------------------
The value 20 hardcoded was used because it is the minimum of the available viewSize.
With the change you have done the problem is that when you select, lets say 30 as viewSize, and you have a listSize of 25 there is no way to switch back to viewSize 20 because the pagination is not rendered anymore.
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20
> ---------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3194
> URL: https://issues.apache.org/jira/browse/OFBIZ-3194
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Divesh Dutta
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBiz-3194.patch
>
>
> Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20.
> In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
> {<#if listSize gt 20>}
> This can be changed to
> {<#if listSize gt viewSize>}
> as viewSize is passed as parameter in macro renderNextPrev. This is also reported by Matthieu Bollot in developer mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.